Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/profile popup data incorrect #230

Merged
merged 9 commits into from
Sep 11, 2023

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Sep 9, 2023

Resolves #195
Resolves #206

@mattyg mattyg changed the base branch from main to fix/profile-not-found-errors September 9, 2023 21:20
@mattyg mattyg requested a review from jost-s September 9, 2023 21:23
@jost-s
Copy link
Collaborator

jost-s commented Sep 11, 2023

Hashtag list is still displaying incorrect mew:
image

@jost-s
Copy link
Collaborator

jost-s commented Sep 11, 2023

Profile popup works mostly now, however right after creating a new mew with a mention and then hovering it, it shows the nickname of the current user, not the hovered profile user
image

Copy link
Collaborator

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments above

@mattyg
Copy link
Collaborator Author

mattyg commented Sep 11, 2023

see comments above

did you run npm install for this branch? -- there are updates to deps that had a bug related to this issue. I can't reproduce what you're seeing

@mattyg mattyg requested a review from jost-s September 11, 2023 18:39
@jost-s
Copy link
Collaborator

jost-s commented Sep 11, 2023

True, I hadn't. Works fine now

@mattyg mattyg merged commit 515ae86 into fix/profile-not-found-errors Sep 11, 2023
1 of 2 checks passed
@mattyg mattyg deleted the fix/profile-popup-data-incorrect branch September 11, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hashtags list displays incorrect mew Profile popup on mentions inconsistently shows incorrect profile data
2 participants