Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _elastica_numba folder while keeping _elastica_numba.py #138

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Remove _elastica_numba folder while keeping _elastica_numba.py #138

merged 1 commit into from
Jul 15, 2022

Conversation

bhosale2
Copy link
Collaborator

Fixes #136.

@bhosale2 bhosale2 added the enhancement New feature or request label Jul 15, 2022
@bhosale2 bhosale2 self-assigned this Jul 15, 2022
@bhosale2 bhosale2 linked an issue Jul 15, 2022 that may be closed by this pull request
Removing _elastica_numba folder and add _elastica_numba.py for user notification #136
Closed
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jul 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #138 (af1b7b7) into update-0.3.0 (6e00f63) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           update-0.3.0     #138   +/-   ##
=============================================
  Coverage         87.41%   87.41%           
=============================================
  Files                44       44           
  Lines              2639     2639           
  Branches            355      355           
=============================================
  Hits               2307     2307           
  Misses              310      310           
  Partials             22       22
Impacted Files Coverage Δ
elastica/_elastica_numba.py 0.00% <ø> (ø)
elastica/dissipation.py 95.45% <100.00%> (ø)
elastica/typing.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d7201...af1b7b7. Read the comment docs.

skim0119
skim0119 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit ab07dba into GazzolaLab:update-0.3.0 Jul 15, 2022
@bhosale2 bhosale2 deleted the 136_elastica_numba_folder_removal branch July 15, 2022 21:16
@bhosale2 bhosale2 mentioned this pull request Jul 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skim0119 skim0119 skim0119 approved these changes

@armantekinalp armantekinalp Awaiting requested review from armantekinalp

Assignees

@bhosale2 bhosale2

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging this pull request may close these issues.

Removing _elastica_numba folder and add _elastica_numba.py for user notification
3 participants
@bhosale2 @codecov-commenter @skim0119