Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing _elastica_numba folder and add _elastica_numba.py for user notification #136

Closed
bhosale2 opened this issue Jul 14, 2022 · 2 comments · Fixed by #138
Closed

Removing _elastica_numba folder and add _elastica_numba.py for user notification #136

bhosale2 opened this issue Jul 14, 2022 · 2 comments · Fixed by #138
Assignees
Labels
enhancement New feature or request update Update the codebase
Milestone

Comments

@bhosale2
Copy link
Collaborator

Currently numba has become a default feature in pyelastica and the separate _elastica_numba module is deprecated since the past few version releases. The presence of that folder in future releases may create confusion as to if numba needs to be turned on or off in the simulator. As such, after discussion with @armantekinalp, we feel it may be time to remove that module altogether.

@bhosale2 bhosale2 added enhancement New feature or request update Update the codebase labels Jul 14, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jul 14, 2022
@skim0119
Copy link
Collaborator

I remember removing _elastica_numba folder before and replaced with _elastica_numba.py for v0.3.0. I think the folder still exists because some past rebasing skipped removing boundary_condition.py file. Feel free to remove the folder and make a patch directly.

We still have _elastica_numba.py for user notification. In v0.2, we left all the files and threw warnings. These warnings will be changed to an error in v0.3. (Same story for _elastica_numpy.py) The purpose is to throw ImportError with our own message saying the user can directly import modules without specifying _elastica_numba. I think this message is needed because we have quite a bit of legacy code scattered around.

@bhosale2 bhosale2 changed the title Removing _elastica_numba module Removing _elastica_numba folder and add _elastica_numba.py for user notification Jul 15, 2022
@bhosale2
Copy link
Collaborator Author

Closed via #138.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request update Update the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants