Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile dependency updates for scripts #235

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

nathanweeks
Copy link
Contributor

Fix #169 , including additional dependencies:

  • diamond-aligner (recommended over blastp I assume?) for aa2nonred.pl
  • libyaml-perl for yaml2gff.1.4.pl
  • libdbd-mysql-perl for autoAug.pl (though note PASA also supports SQLite)
  • python3-biopython for fix_in_frame_stop_codon_genes.py and getAnnoFastaFromJoingenes.py (installed using --no-install-recommends to avoid installing ncbi-blast+; if it's desired that still be installed as an alternative to diamond for aa2nonred.pl, just remove that option)
  • cdbfasta for fix_in_frame_stop_codon_genes.py

Also, this PR addresses a syntax issue in extractAnno.py revealed by Python 3.8.5:

root@aaed5cebd134:~/augustus/scripts# python3 --version
Python 3.8.5
root@aaed5cebd134:~/augustus/scripts# ./extractAnno.py -h
./extractAnno.py:37: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  split = [x for x in line.split("\t") if x is not ""] 
./extractAnno.py:61: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  split = [x for x in line.split("\t") if x is not ""] 
usage: extractAnno.py [-h] [-c CHUNKS [CHUNKS ...]]

(see https://adamj.eu/tech/2020/01/21/why-does-python-3-8-syntaxwarning-for-is-literal/ for a description of this warning)

Finally, it's handy if the scripts directory is in the PATH (per the Augustus Install locally directions). This PR adds the scripts/ directory to PATH, and adds the execute bit to several scripts that lacked it.

Change file mode to make several scripts executable

Fix SyntaxWarning in extractAnno.py

Add scripts to PATH
@MarioStanke
Copy link
Contributor

Thanks, Nathan.
Yes, diamond is recommended over blastp due to speed.
Thanks for adding the dependencies, and the other fixes.

@MarioStanke MarioStanke merged commit b75e408 into Gaius-Augustus:master Dec 14, 2020
@nathanweeks nathanweeks deleted the script-deps branch December 14, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker image missing perl libraries
2 participants