Various additions

[Gordon-Frohman]

Again, another PR to track my progress.

Currently done:

• Trophies for minor bosses and Questing Ram (properly textured by yours truly)
• Backported Yeti sounds
• Trophies now make noises of corresponding bosses when clicked
• Trophies now can be worn, just like vanilla skulls
  • Fireflies, cicadas and moonworms can be worn on your head as well
  • Both trophies and critters can be equipped with Shift+rightclicking
• Fixed a bug where clicking a trophy with mouse wheel wouldn't give you a trophy item
• Trophy pedestal can finally be collected once deactivated
• Trophy pedestal now gives a comparator output depending on progression order of the trophy on top
• Fixed Aurora Palace map icon
• Compressed blocks now can be used as a beacon base
• Material traits:
  • Fiery blocks now provide light, sustain fire and damage player standing on top (unless he/she is wearing fiery boots or sneaking), just like magma blocks from future versions
  • Fur and Steeleaf blocks now reduse fall damage by 75% and 25% accordingly
• New Fiery metal block model - with glowing outline and seamless textures
• Huge water lily and thorn rose can now be crafted into magenta and red dye accordingly
• Fiery blood/tears are now registered under same OreDictionary entry - "fieryEssence". All the recipes using them changed accordingly
• Fiery armor can now be crafted directly from intact iron armor and appropriate amount of fiery blood/tears
• Wispy clouds can be harvested with silk touch tools
• "Twilight Hunter" and progression achievements now can only be gained when in Twilight Forest
• Mosquitos now count as arthropods
• Skeleton druids now won't cast without a hoe (in case you can take it away from it somehow)
• Every boss now has its own spawner (names for those were fixed as well)
• Every boss now leaves its spawner behind when going into peaceful
  • Knight phantoms spawner keeps record of knights left to prevent exp farming abuse
• Ice bomb now adds snow to already existing layers
  • Shape in which snow will generate is more circular now
• Charms effects finally render properly
• Charms of Keeping now keep inventory even if you log out instead of respawning immediately
• Phantom armor is now kept on death, regardless of having any Charms of Keeping
• Thorn roses can now be placed on leaves and any blocks that can sustain flowers
• Crumble Horn can now crumble a lot more blocks
• Chests made of twilight wood (trapped chests as well)
• Burnt thorns can now be broken with projectiles
• Bugs can now be killed with projectiles
• Cicadas now shut up once broken

To be done (notes made for myself):

Easy:

• New castle blocks
• Rebalancing giant tools (?)
• Questing ram spawn egg
• Death tomes enchanted books drop (how rare?)
• Alpha yeti should throw ice bombs during rampage
• Golden minotaur axe (WHY?)
• Redo knightmetal bonus damage depending on amount of armor pieces
• Make beanstalk pop through blocks
• Cicada jars (WHYYYYYY?)
• Redo Experiment 115 comparator output (again, do we need this?)
• No fire enchantments on ice stuff
• Clouds should reduse fall damage
• Giants should step over taller obstacles

Medium:

• Anti-builder block blacklist
• Blocked back portal option
• TF spawn option
• Non-fiery lightning option
• Driud hut rework (+ more variants and basement)
• Longer reach for giant tools
• Scepter of Fortification
• Aurolized glass - should color beacon light accordingly
• Moon dial
• Clover patches
• Seeker bow hostile priority and avoid targets it can't hit
• Fallen logs generation redone (do we really need this?)
• Progression achievements depending on hitting boss at least once
• Usage of scepters, moonworm queen, transforming powder, horn, fan and ice bombs with dispencer
• New enchantments, only found in loot:
  • Fire React: has a chance to set the attacker on fire when worn. Incompatible with chill aura and thorns.
  • Chill Aura: has a chance to apply frosted to the attacker. Incompatible with fire react and thorns.
  • Stuff for Block and Chain (It shouldn't break blocks by default now):
    • Destruction: 3 levels. Level 1 enables block breaking, higher levels increase its mining tier up to iron.
• New wells (which ones exactly?)
• Potion flasks (to be done when lich tower update comes out)
• Climb root strands (do we really need this?)
• Eat torchberries to glow
• Baby skeleton druids: only spawn on swarm spiders
• Burn mobs with the Lamp of Cinders
• TF plants flowerpot support
• Ability for Lich to absorb mobs around him and regenerate

Hard:

• Shapeless portals (?)
• New potion effect for ice damage, instead of slowness
  • Fiery, Fur and Yeti armor should make player immune to ice damage
• Immersive Engineering support (one day maybe)
• New minoshroom attack
• Hollow logs that can be filled with stuff (if can be done at all)
• Red thread (if possible)
• Beanstalk growing animation (can I do that?)
• Cloud stuff:
  • Weather mimicing for fluffy clouds
  • Being ignored by weather (pass through) for wispy clouds
  • Rainy and snowy clouds

[LewisSaber]

OMG OMG OMG

[Gordon-Frohman]

OMG OMG OMG

Spent all day tweaking this. Feel free to try it out)

[LewisSaber]

Yo man thats insane, I have been dreaming of this for years, thank you so much!!!

[Gordon-Frohman]

You're welcome!

[Dream-Master]

@LewisSaber can you spit fire now ?

[Gordon-Frohman]

Using the addNewStalactite method, you can add stalactites made of various blocks without affecting vanilla ones. You can also adjust:

1. Level of the hill these stalactites would generate in
2. Their min/max/relative size
3. Chance of them generating compared to the others

For example I used it to generate these huge fur stalactites in hills of any level. But, as you can see, no other stalactites are affected by this:

[YannickMG]

Using the addNewStalactite method, you can add stalactites made of various blocks without affecting vanilla ones. You can also adjust:

...

I like your approach of defining new stalactites. I'm curious as to why that couldn't have been feedback on #41 rather than a new implementation, but no matter.

I created #41 as a result of feedback by @Dream-Master for a project that involves replacing all the vanilla ore stalactites by other ores, mainly those added by Gregtech. This feature should match his requirements to be implemented. At the very least support is needed to completely remove the vanilla ores, if not by API then by config.

It should also be easy for the user of your API to use alternative methods of setting the ore block such as Gregtech's GT_TileEntity_Ores.setOreBlock. #36 did that directly by adding a dependency on Gregtech and I sought to be more flexible by letting the caller use their own dependencies in #41. You should then make it possible at least to set ores the Gregtech way, but preferably in any way the caller chooses.

Finally I will note that until @Dream-Master finishes drafting the requirements for the TF stalactite ore replacement project then any merge might be premature as it might lack a feature we'll end up needing.

Also unless you want to delay this PR, may I suggest you make a separate PR for the stalactites? The functionality is quite separate from the rest of your PR.

[Gordon-Frohman]

I'm curious as to why that couldn't have been feedback on #41 rather than a new implementation, but no matter.

Sorry, GitHub is still a pretty new platform for me, so I don't know all of it functionality. :D It was just easier for me to add all of this in already existing PR.

At the very least support is needed to completely remove the vanilla ores, if not by API then by config.

Got it. It shouldn't be very difficult to do. For example I can add a method to clear all the stalactite lists, that can be called from GT.

It should also be easy for the user of your API to use alternative methods of setting the ore block such as Gregtech's GT_TileEntity_Ores.setOreBlock. #36 did that directly by adding a dependency on Gregtech and I sought to be more flexible by letting the caller use their own dependencies in #41. You should then make it possible at least to set ores the Gregtech way, but preferably in any way the caller chooses.

Okay, my bad, I guess I didn't know enough of GT ore generation. I'll read about it and figure out a way of implementing it. Or we can just use your PR, I guess our codes shouldn't really conflict

Also unless you want to delay this PR, may I suggest you make a separate PR for the stalactites? The functionality is quite separate from the rest of your PR.

Oh, don't worry about it. The functionality of this PR is just "take all I've added and mash it all together". And the list of things I still have to add is massive, so I don't expect a merge any time soon

[Gordon-Frohman]

So, @YannickMG, if I understand correctly, the whole idea of your PR was to check if a block about to be placed has a GT version and, if it does, replace it with it?
If it is so, then your approach is the best version of doing it to my mind. Maybe I should add my api to your PR then? Then we would have both support for GT ores and option to add ores from other mods

[Caedis]

Just a heads up, GT_TileEntity_Ores will be going away soon-ish with the material rewrite

[Gordon-Frohman]

Just a heads up, GT_TileEntity_Ores will be going away soon-ish with the material rewrite

Huh
And how will ore placement look after it?

[Caedis]

The material rewrite will include the block metadata expansion so that instead of a block being limited to 15 metadata, it will have up to 32k i believe.

The reason why ores are current TEs are so they can store NBT on if they are natural so that the MBM can't mine user placed ores.

[Gordon-Frohman]

I was just going to add an option to set up metadata for stalactite blocks
Is this going to be enough?

[mitchej123]

As a note we support TF outside of the pack, so config options are generally warranted for anything balance related.

Additionally not registering recipes when dream craft is present and adding elsewhere is significantly faster than add, remove, add.

[Gordon-Frohman]

Additionally not registering recipes when dream craft is present and adding elsewhere is significantly faster than add, remove, add.

Well, I've done it. Are we cool now?

[Ethryan]

crash-2024-06-24_23.38.52-server.txt
crash-2024-06-24_23.49.04-client.txt
@Gordon-Frohman , Cicadas shouldn't crash the server when broken.

[Gordon-Frohman]

Cicadas shouldn't crash the server when broken.

Oh, they do? Nasty little things. Will look into this

[Gordon-Frohman]

@Ethryan, I think I fixed it. No crashes for me at least. Can you check it?

[Ethryan]

@Ethryan, I think I fixed it. No crashes for me at least. Can you check it?

On it.

[Dream-Master]

@Gordon-Frohman will do a new pre tag in a bit

[Ethryan]

@Ethryan, I think I fixed it. No crashes for me at least. Can you check it?

Tested and the area that 100 % crashed me before don't anymore, think I consider this fixed.

[Dream-Master]

@Lyfts @chochem @Caedis @Ethryan @mitchej123 @YannickMG anything else need to be done before merge ?

[Caedis]

Looks good to me

[Ethryan]

Me too.

[Gordon-Frohman]

Should be fixed now
@Lyfts, what do you think?

[Ethryan]

I got a question:
While I took a peek at your latest commit, I noticed that you are adding obfuscated values. Why?

It makes the code so much more readable if you use human language and can tell what the values represent. Even if it is just aX, aY, aZ as block coordinates for example.

[Gordon-Frohman]

Well, there're two reasons for this
Firstly, sometimes I just copy obfuscated vanilla code. I can (and will) make it more readable if I know the purpose of such variables/methods
And secondly, some of functions I added are overriding obfuscated functions in parent classes. I can't just rename these

[Lyfts]

I believe all of the bigger bugs have been addressed at this point, very good job!

[Dream-Master]

@Gordon-Frohman we merge this now. If you want to add the changes @Ethryan suggest make a new pr.

[Gordon-Frohman]

@Gordon-Frohman we merge this now. If you want to add the changes @Ethryan suggest make a new pr.

Sure thing
I was going to do just that

[AetherLegacyPro]

Wow this is amazing! Keep up the great work!

[Gordon-Frohman]

Wow this is amazing! Keep up the great work!

Thank you!

[brandyyn]

@Gordon-Frohman

The twilight forest is too easy in modded minecraft and I think it'd be a good idea to make it more difficult, especially since people practically 4 shot the naga even in GTNH- Maybe add configs to increase/change the twilight forest mob's health? The configs would be there so you wouldn't have to balance it, the packdevs would, say I wanted to fight a naga with 500 hp, i would just set it in the config. At the very least the bosses. Maybe the lich can have phases instead of just losing all his shields and then you can kill him, what if he regenerates some shields in each phase?

[Dream-Master]

Yea I like the idea make the fights a bit more challenging. Make the Naga immune to arrows