Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds stalactite ore placing override API #41

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YannickMG
Copy link

@YannickMG YannickMG commented Feb 24, 2024

The intent is to allow the core mod (or any other mod) to specify which ores should be in the stalactites by providing a method to place that stalactite's blocks.

This is an alternative to the method used in #36.

image
image

Thanks to Minepolz320 for the original idea.

Copy link

Warning: 2 uncommitted changes
#42

@Dream-Master Dream-Master requested a review from a team February 24, 2024 05:28
@YannickMG YannickMG marked this pull request as draft February 24, 2024 12:48
Can replace all the ore in a given stalactite
@YannickMG YannickMG marked this pull request as ready for review February 24, 2024 14:15
@Gordon-Frohman
Copy link

There's one thing I don't really like about this method: you can't really tweak the rarity of the stalactite you're generating, plus you're not really adding a new stalactite, you're just replacing an existing one. I would rather add an option to add new stalactites, that would've compete for generation with vanilla ones. I guess I'll have to do it in my PR)

@Gordon-Frohman
Copy link

You can check my version out in #44

@Gordon-Frohman
Copy link

Did you check how it works with GT ores? Because I'm afraid that it may cause issues similar to those I got

@YannickMG YannickMG marked this pull request as draft May 12, 2024 18:03
@YannickMG
Copy link
Author

In draft pending requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants