This repository has been archived by the owner on May 25, 2024. It is now read-only.
LEG rotation fix #249
Merged
LEG rotation fix #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoleFish
previously requested changes
Apr 6, 2024
Dream-Master
added
ongoing freeze - don't merge
Dream-Master
approved these changes
May 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Large Essentia Generator could only be rotated to two possible orientations: either with the main structure below the controller (if the face of the controller was pointed towards any cardinal direction), or with the structure on the south side of the controller (if the face of the controller was pointing up or down). This was caused by the LEG attempting to do its own rotation logic (??) instead of inheriting the one from
GT_MetaTileEntity_EnhancedMultiblockBaseand reimplementing it poorly.This PR makes it so that the LEG can be rotated to any direction, allowing for more varied and compact setups. Flipping the LEG is still allowed, although it makes no functional difference (since the structure is symmetrical).