Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Fix AAL crashing #37

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Fix AAL crashing #37

merged 4 commits into from
Apr 18, 2024

Conversation

HoleFish
Copy link
Contributor

Fixes GTNewHorizons/GT-New-Horizons-Modpack#15848, mainly by reverting #31 and saving 2 variables curBatchItemsFromME and curBatchFluidsFromME as an alternative.
I'm not sure how it will do to GTNewHorizons/GT-New-Horizons-Modpack#15962, GTNewHorizons/GT-New-Horizons-Modpack#15612 and GTNewHorizons/GT-New-Horizons-Modpack#15836, but the previous getInputHatchContent() was totally wrong. Need tests to confirm whether those issues are fixed.

@HoleFish HoleFish changed the title Fix AAL Fix AAL crashing Apr 15, 2024
@HoleFish HoleFish requested review from Glease, NotAPenguin0 and a team April 15, 2024 14:19
Dream-Master and others added 2 commits April 16, 2024 22:25
(cherry picked from commit 1afdfc9c51ee6008150cda85a104e4694e4251e9)
Copy link
Contributor

@NotAPenguin0 NotAPenguin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see nothing wrong with the code, and testing proves it works fine, so looks good to me.

@MaGeBZz
Copy link

MaGeBZz commented Apr 18, 2024

I see nothing wrong with the code, and testing proves it works fine, so looks good to me.

Yeah I tested that, even in a weird scenario that isn't recipe x2 and everything worked like intended, can confirm that

@Dream-Master Dream-Master merged commit 0f6bb0f into GTNewHorizons:master Apr 18, 2024
2 checks passed
@HoleFish HoleFish deleted the fix branch April 19, 2024 05:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AALs can't work at maximum slice
4 participants