Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stocking input hatches cause AALs to Fail/void all crafts when not enough items to start crafting first slice #15836

Closed
3 tasks done
cytrus224 opened this issue Mar 26, 2024 · 4 comments
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed

Comments

@cytrus224
Copy link

Your GTNH Discord Username

Cytrus

Your Pack Version

2.6.0 beta

Your Server

private MP server

Java Version

Java 21

Type of Server

Don't know

Your Expectation

Stocking hatches work fine with AALs

The Reality

316829945-ddb9d44c-cfe9-449c-9c87-069b4b6cff1b
My setup: Dual interface inputs items and fluids into subnet, which stores items and fluids on ME Drive disks. Items and fluids are distributed to multiple AALs via stocking input buses and hatches.
When big craft is close to finished(last items are being crafted in AALs), AALs "fails" to pull items&fluids, because there is no more to craft, and voids all crafts that are being crafted in other slices.
I have 12 Pico circuit AALs, 4 Gallifreyan TIme Dilation AALs, 12 Optical Mainframe AALs, all of them have this issue.

Your Proposal

Fix AALs so they do not void all pending crafts when trying to start a new slice

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@cytrus224 cytrus224 added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels Mar 26, 2024
@miaowwwwww
Copy link
Member

this could be the same with what i mentioned here. I could not figure out what was going on. #15612

@Tomekosi
Copy link

this could be the same with what i mentioned here. I could not figure out what was going on. #15612

It is the same issue, I'm playing on the very same server as Cytrus, and this happens all the time

@cytrus224
Copy link
Author

Found out that if AALs are overclocked enough and 1ticking slices, they tend not to crash anymore

Dream-Master added a commit to GTNewHorizons/GigaGramFab that referenced this issue Apr 18, 2024
Fixes
GTNewHorizons/GT-New-Horizons-Modpack#15848,
mainly by reverting #31 and saving 2 variables `curBatchItemsFromME` and
`curBatchFluidsFromME` as an alternative.
I'm not sure how it will do to
GTNewHorizons/GT-New-Horizons-Modpack#15962,
GTNewHorizons/GT-New-Horizons-Modpack#15612
and
GTNewHorizons/GT-New-Horizons-Modpack#15836,
but the previous `getInputHatchContent()` was totally wrong. Need tests
to confirm whether those issues are fixed.

---------

Co-authored-by: Martin Robertz <[email protected]>
@NotAPenguin0
Copy link
Contributor

Fixed in GTNewHorizons/GigaGramFab@0f6bb0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed
Projects
None yet
Development

No branches or pull requests

4 participants