Add LANG files for BLS. Some are "missing". #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why isn't this covered by the usage of txloader? |
|
Even though we use txloader, it doesn't seem to load in game. Perhaps BLS loads its .lang files before everything else. |
miozune
reviewed
Mar 12, 2024
|
I have removed the incomplete translations. I hope this correctly addresses the issue. |
miozune
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GTNewHorizons/GTNH-Translations#8 (comment) for more context.
A problem I saw is that some translations are not done (de_DE, ko_KR and ja_JP). Maybe we should wait until they are translated to include them? Nonetheless, the other translations seem to be complete.