Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some files can't have multiple locales at the same time #8

Closed
3 tasks done
boubou19 opened this issue Mar 8, 2024 · 7 comments
Closed
3 tasks done

Some files can't have multiple locales at the same time #8

boubou19 opened this issue Mar 8, 2024 · 7 comments
Labels
enhancement New feature or request urgent

Comments

@boubou19
Copy link
Member

boubou19 commented Mar 8, 2024

I tried unzipping all the locale releases, and i got some file conflicts. So this makes it impossible for now to ship the locales in nightlies nor stable releases. Here is the list of files that needs to be dealt with:

  • ./config/CustomMainMenu/*
  • ./config/InGameInfoXML
  • ./config/GTNewHorizons/CustomToolTips.xml
@boubou19 boubou19 added enhancement New feature or request urgent labels Mar 8, 2024
@boubou19
Copy link
Member Author

boubou19 commented Mar 8, 2024

So we have a fork of https://github.com/GTNewHorizons/Custom-Main-Menu and https://github.com/GTNewHorizons/InGame-Info-XML so at least we don't face ARR mods

@IcaroKaue
Copy link
Collaborator

This is low priority, but iirc there is also craftpresence.json. That might mess things up.

@IcaroKaue
Copy link
Collaborator

IcaroKaue commented Mar 10, 2024

Also, there are the mods which are currently unsupported:

  • IC2 - Uses a different file called "xx_XX.properties" at [IC2].jar/ic2/lang/. (Note: this already has a translation, however it appears to be inconsistent and incomplete in many cases.)
  • BetterLoadingScreen - Though there is a xx_XX.lang in the txloader folder for it, it does not appear to be translated. Perhaps it does not load quick enough?

Please comment if there are any mods I missed.

@miozune
Copy link
Member

miozune commented Mar 11, 2024

  • BetterLoadingScreen - Though there is a xx_XX.lang in the txloader folder for it, it does not appear to be translated. Perhaps it does not load quick enough?

Are you talking about https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/tree/master/config/txloader/forceload/betterloadingscreen/textures/backgrounds or https://github.com/GTNewHorizons/GTNH-Translations/blob/master/pt_BR/config/Betterloadingscreen/tips/pt_BR.txt?

@miozune
Copy link
Member

miozune commented Mar 11, 2024

So it turns out that BLS has its own translation loader, just for translating "Minecraft Initialization" where lang resources are not loaded yet. Maybe we can place translation back to mod jar and call it a day.

@miozune
Copy link
Member

miozune commented Mar 11, 2024

Closing as the original goal has been achieved. @IcaroKaue If you want to ship translated craftpresence.json with the modpack, please contact the dev of CraftPresence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request urgent
Projects
None yet
Development

No branches or pull requests

3 participants