Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve #24 and #25 #26

Merged
merged 6 commits into from
May 4, 2022
Merged

Solve #24 and #25 #26

merged 6 commits into from
May 4, 2022

Conversation

ppouchin
Copy link
Member

@ppouchin ppouchin commented May 4, 2022

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.3% 91.3% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #26 (6ca75a2) into main (58830ac) will decrease coverage by 0.02%.
The diff coverage is 89.02%.

@@             Coverage Diff              @@
##               main      #26      +/-   ##
============================================
- Coverage     91.89%   91.87%   -0.03%     
- Complexity      752      775      +23     
============================================
  Files            37       37              
  Lines          2246     2325      +79     
  Branches        154      161       +7     
============================================
+ Hits           2064     2136      +72     
- Misses          146      152       +6     
- Partials         36       37       +1     
Impacted Files Coverage Δ
...ero/repository/GenericRepositoryObjectWrapper.java 86.70% <83.33%> (-1.79%) ⬇️
...java/fr/igred/omero/repository/DatasetWrapper.java 89.30% <95.83%> (+1.16%) ⬆️
src/main/java/fr/igred/omero/Client.java 87.25% <100.00%> (+0.58%) ⬆️
...igred/omero/annotations/FileAnnotationWrapper.java 81.81% <100.00%> (+0.56%) ⬆️
...ed/omero/annotations/GenericAnnotationWrapper.java 93.10% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58830ac...6ca75a2. Read the comment docs.

@ppouchin ppouchin merged commit 5b36e30 into main May 4, 2022
@ppouchin ppouchin deleted the copy-annotations branch May 4, 2022 22:14
ppouchin added a commit that referenced this pull request May 24, 2022
* Add methods to ImageWrapper: isOrphaned and getFilesetImages
* Add method to count links from annotations
* Add method to replace attachments
* Add argument to determine if images should be deleted when replaced
* Add methods to delete multiple objects at once
* Add method to get images from a project using the datasets names and the images names
* Add method GenericObjectWrapper#distinct to filter collections and keep distinct objects
* Replace lists of unknown capacity by lists of lists and flatmap
* Add tests
* Refactor code to create/remove files in tests
* Improve Javadoc
* Replace color concatenation in tests logs by String#format()
* Minor code improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant