Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve on PR #26 for issues #24 and #25 #29

Merged
merged 20 commits into from
May 24, 2022
Merged

Improve on PR #26 for issues #24 and #25 #29

merged 20 commits into from
May 24, 2022

Conversation

ppouchin
Copy link
Member

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.2% 97.2% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #29 (1044462) into main (0dbb038) will increase coverage by 0.15%.
The diff coverage is 95.85%.

@@             Coverage Diff              @@
##               main      #29      +/-   ##
============================================
+ Coverage     91.72%   91.87%   +0.15%     
- Complexity      782      808      +26     
============================================
  Files            37       37              
  Lines          2343     2448     +105     
  Branches        166      180      +14     
============================================
+ Hits           2149     2249     +100     
- Misses          152      153       +1     
- Partials         42       46       +4     
Impacted Files Coverage Δ
...igred/omero/annotations/FileAnnotationWrapper.java 81.81% <ø> (ø)
.../java/fr/igred/omero/annotations/TableWrapper.java 93.47% <ø> (ø)
...n/java/fr/igred/omero/repository/PlateWrapper.java 88.57% <ø> (ø)
...a/fr/igred/omero/repository/WellSampleWrapper.java 66.66% <ø> (ø)
src/main/java/fr/igred/omero/roi/ROIWrapper.java 95.93% <ø> (ø)
src/main/java/fr/igred/omero/roi/ShapeList.java 95.00% <ø> (ø)
src/main/java/fr/igred/omero/GatewayWrapper.java 86.90% <83.33%> (-0.28%) ⬇️
...main/java/fr/igred/omero/GenericObjectWrapper.java 91.89% <88.88%> (-0.97%) ⬇️
...n/java/fr/igred/omero/repository/ImageWrapper.java 88.94% <90.90%> (+0.11%) ⬆️
...java/fr/igred/omero/repository/DatasetWrapper.java 89.61% <92.10%> (+0.11%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dbb038...1044462. Read the comment docs.

@ppouchin ppouchin merged commit 67f7050 into main May 24, 2022
@ppouchin ppouchin deleted the replace branch May 24, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant