Update to syn 2.0, and serde_derive_internals 0.29 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be ok to bump the MSRV? 1.60 is almost a year old at this point. |
|
This is for one required to support the |
|
@Jake-Shadle Thank you very much for your PR! I decided to merge in a different change (#281) which does the same package updates with fewer other code changes, but your PR was extremely useful to see what kind of changes needed to be made to handle the breaking changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates schemars_derive to use syn 2.0 and serde_derive_internals as much of crate ecosystem has moved from syn 1.0 and it's best to avoid duplicate dependencies, especially in proc macros.
Resolves: #262