-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide JSON schema for deny.toml
file for better IDE experience
#632
Comments
Seems reasonable. |
I'd like to claim this issue, if no one else is working on it |
Sure, go for it. Note you'll not be able to use schemars, both because serde is no longer used for the configuration, and it also has really outdated dependencies that I'd rather not burden cargo-deny with eg. GREsau/schemars#269 |
I see, that's a bummer. Although In theory we could write the JSON schema manually. It is human-readable and its format also has its own schema so IDE's are helpful with writing that file. I'm thinking of using YAML for that definition though and converting that YAML to JSON. This is because JSON doesn't play well with multiline strings, which appear in documentation, and also has no support comments. On the other hand with the manual approach there is a lot of flexibility and it's possible to define complex validations. |
I haven't thought about implementation much yet since you only opened this recently, but ideally it would be something along these lines:
|
Makes sense, I'll try to find a way to make the JSON schema the source of the truth for the mdbook as well |
It's possible to associate a JSON schema with a TOML file to make a VSCode extension such as "Even Better TOML" (taplo) provide completions, documentation, type hints and validation in the IDE. Details on the config are here.
I propose cargo-deny to provide a JSON schema definition file that completely describes the
deny.toml
file format.Discoverability
I propose to submit the schema to the JSON Schema Store such that TOML IDE plugins can discover the schema without any additional configs.
Alternatively people could set the file schema with
#:schema {schema-uri-here}
comment at the top of the file, but it would be better if that was automatic via the JSON Schema Store.Implementation notes
I'm not sure how exactly this should be implemented, but I know of
schemars
crate that can generate a JSON schema automatically from Rust code.The text was updated successfully, but these errors were encountered: