Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the shader input IsOffChip #2861

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Remove the shader input IsOffChip #2861

merged 1 commit into from
Dec 12, 2023

Conversation

amdrexu
Copy link
Contributor

@amdrexu amdrexu commented Dec 3, 2023

This SGPR was originally for pre-GFX9 when tessellation on-chip mode is available. Now, this SGPR is necessary when merged shader doesn't provide it since tessellation is always in off-chip mode.

@qiaojbao
Copy link
Collaborator

qiaojbao commented Dec 4, 2023

21:05:25 [3840/69215] Pass: 875 Fail: 408 Skip: 1131 ExpectedFail: 0 UnexpectedPass: 0 Crash: 22 Timeout: 0 Missing: 748 Flake: 656 Duration: 58:20 Remaining: 16:33:07
21:05:31 [11776/69163] Pass: 4819 Fail: 403 Skip: 3501 ExpectedFail: 0 UnexpectedPass: 0 Crash: 17 Timeout: 4 Missing: 2244 Flake: 788 Duration: 58:20 Remaining: 4:44:16
Seems hang.

@amdrexu
Copy link
Contributor Author

amdrexu commented Dec 4, 2023

Will rebase this PR once #2860 is accepted.

@amdvlk-admin
Copy link

Test summary for commit 2e2ebcd

CTS tests (Failed: 285/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 34956/69215 (50.5%)
    • Failed: 285/69215 (0.4%)

      Failures:

      FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance.vert_tess_geom.1_7
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance.vert_tess_geom.2_6
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance.vert_tess_geom.4_4_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance.vert_tess_geom.5_3_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance.vert_tess_geom.6_2_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance.vert_tess_geom.7_1
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance.vert_tess_geom.7_1_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.1_7
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.1_7_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.2_6
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.2_6_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.3_5
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.3_5_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.4_4_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.5_3_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.6_2
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.6_2_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.7_1
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.7_1_fragmentshader_read
Stack trace: Crash

FAILURE: dEQP-VK.clipping.user_defined.clip_cull_distance_dynamic_index.vert_tess_geom.8_fragmentshader_read
Stack trace: Crash
...

    • Not Supported: 33974/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@amdvlk-admin
Copy link

Test summary for commit 4bcc87f

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@amdrexu
Remove the shader input IsOffChip
630a2bd 
This SGPR was originally for pre-GFX9 when tessellation on-chip mode is
available. Now, this SGPR is necessary when merged shader doesn't
provide it since tessellation is always in off-chip mode.

Also, always make the SGPR corresponding to offChipLdsBase present
because we are always on off-chip tessellation mode.
@amdrexu amdrexu marked this pull request as ready for review December 5, 2023 09:10
@amdrexu amdrexu requested a review from a team as a code owner December 5, 2023 09:10
@amdvlk-admin
Copy link

Test summary for commit 630a2bd

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35163/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34000/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35241/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33974/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@amdrexu amdrexu merged commit 7dbe263 into GPUOpen-Drivers:dev Dec 12, 2023
10 checks passed
amdrexu added a commit to amdrexu/llpc that referenced this pull request Dec 14, 2023
@amdrexu
Fix a regression of removing isOffChip input
f9bdba5 
This is to fix a regression of
GPUOpen-Drivers#2861. When TES is mapped to
HW VS (no NGG), this SGPR must be present.
@amdrexu amdrexu mentioned this pull request Dec 14, 2023
Merged
amdrexu added a commit to amdrexu/llpc that referenced this pull request Dec 14, 2023
@amdrexu
Fix a regression of removing isOffChip input
0c004db 
This is to fix a regression of
GPUOpen-Drivers#2861. When TES is mapped to
HW VS (no NGG), this SGPR must be present.
amdrexu added a commit that referenced this pull request Dec 16, 2023
@amdrexu
Fix a regression of removing isOffChip input
796a333 
This is to fix a regression of
#2861. When TES is mapped to
HW VS (no NGG), this SGPR must be present.
qiaojbao pushed a commit that referenced this pull request Jan 2, 2024
@amdrexu @qiaojbao
Fix a regression of removing isOffChip input
7eda643 
This is to fix a regression of
#2861. When TES is mapped to
HW VS (no NGG), this SGPR must be present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amdrexu @qiaojbao @amdvlk-admin @nhaehnle