Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the method isTessOffChip #2860

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Remove the method isTessOffChip #2860

merged 1 commit into from
Dec 5, 2023

Conversation

amdrexu
Copy link
Contributor

@amdrexu amdrexu commented Dec 3, 2023

On GFX9+, tessellation is always in off-chip mode. Since we just support GFX10+, the method isTessOffChip always returns TRUE for us.

@amdrexu amdrexu requested a review from a team as a code owner December 3, 2023 10:46
@amdrexu
Remove the method isTessOffChip
66d6c10 
On GFX9+, tessellation is always in off-chip mode. Since we just support
GFX10+, the method isTessOffChip always returns TRUE for us.
@amdvlk-admin
Copy link

Test summary for commit a84beb9

CTS tests (Failed: 4349/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 33037/69228 (47.7%)
    • Failed: 2174/69228 (3.1%)

      Failures:

      FAILURE: dEQP-VK.binding_model.descriptor_buffer.capture_replay.graphics_tese_combined_image_sampler
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.capture_replay.graphics_tese_storage_texel_buffer
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.embedded_imm_samplers.graphics_tese_buffers2_samplers1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.embedded_imm_samplers.graphics_tese_buffers3_samplers3
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tesc_sampler1_resource15
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tesc_sampler1_resource7
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tese_sampler1_resource1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tese_sampler1_resource15
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_tesc_buffers1_sets1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_tesc_buffers3_sets1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tesc_sets2_push_set1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tesc_sets3_push_set0
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tese_sets4_push_set0
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tesc_sets2_push_set1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tesc_sets3_push_set0
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tese_sets1_push_set0
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tese_sets4_push_set3
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tesc_uniform_buffer
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tese_combined_image_sampler
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tese_storage_image
Stack trace: Crash
...

    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 33067/69215 (47.8%)
    • Failed: 2175/69215 (3.1%)

      Failures:

      FAILURE: dEQP-VK.binding_model.descriptor_buffer.capture_replay.graphics_tese_combined_image_sampler
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.capture_replay.graphics_tese_storage_texel_buffer
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.embedded_imm_samplers.graphics_tese_buffers2_samplers1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.embedded_imm_samplers.graphics_tese_buffers3_samplers3
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tesc_sampler1_resource15
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tesc_sampler1_resource7
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tese_sampler1_resource1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.max.graphics_tese_sampler1_resource15
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_tesc_buffers1_sets1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.multiple.graphics_tesc_buffers3_sets1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tesc_sets2_push_set1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tesc_sets3_push_set0
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_descriptor.graphics_tese_sets4_push_set0
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tesc_sets2_push_set1
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tesc_sets3_push_set0
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tese_sets1_push_set0
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.push_template.graphics_tese_sets4_push_set3
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tesc_uniform_buffer
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tese_combined_image_sampler
Stack trace: Crash

FAILURE: dEQP-VK.binding_model.descriptor_buffer.robust.null_descriptor.graphics_tese_storage_image
Stack trace: Crash
...

    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@amdvlk-admin
Copy link

Test summary for commit 66d6c10

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@amdrexu amdrexu mentioned this pull request Dec 4, 2023
Merged
nhaehnle
nhaehnle approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@amdrexu amdrexu merged commit fe8ddc5 into GPUOpen-Drivers:dev Dec 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amdrexu @amdvlk-admin @nhaehnle