Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lock-related tests not flaky #211

Merged
Merged
Changes from 87 commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
09c4579
Semaphore_OneShot
marcin-krystianc Mar 24, 2023
1396411
Consul.Test.SemaphoreTest.Semaphore_OneShot
marcin-krystianc Mar 24, 2023
7bdf33e
Consul.Test.SemaphoreTest.Semaphore_OneShot
marcin-krystianc Mar 24, 2023
169f03b
format
marcin-krystianc Mar 24, 2023
b9d0af5
30
marcin-krystianc Mar 24, 2023
9eada1e
no filter
marcin-krystianc Mar 24, 2023
651a471
one shot
marcin-krystianc Mar 24, 2023
ae56c70
bump
marcin-krystianc Mar 24, 2023
836d559
bump
marcin-krystianc Mar 24, 2023
eed883d
Revert "bump"
marcin-krystianc Mar 24, 2023
ff1ef9e
Revert "Revert "bump""
marcin-krystianc Mar 24, 2023
88a5e48
Revert "Revert "Revert "bump"""
marcin-krystianc Mar 24, 2023
6b37168
Revert "Revert "Revert "Revert "bump""""
marcin-krystianc Mar 24, 2023
e534402
Revert "Revert "Revert "Revert "Revert "bump"""""
marcin-krystianc Mar 24, 2023
5f20fb2
Revert "Revert "Revert "Revert "Revert "Revert "bump""""""
marcin-krystianc Mar 24, 2023
3233e86
semaphoretests
marcin-krystianc Mar 27, 2023
3204a0b
"http_max_conns_per_client" : 1000
marcin-krystianc Mar 27, 2023
786da42
no format
marcin-krystianc Mar 27, 2023
5f4abf2
nl
marcin-krystianc Mar 28, 2023
f4b3953
nl
marcin-krystianc Mar 28, 2023
61319c1
Revert "nl"
marcin-krystianc Mar 28, 2023
b54acaa
tmp
marcin-krystianc Mar 28, 2023
3878482
drop netcoreapp2.1 and netcoreapp3.1 - add net7.0
marcin-krystianc Mar 28, 2023
d7d3136
fix format?
marcin-krystianc Mar 28, 2023
1e261eb
format 6.0.100?
marcin-krystianc Mar 28, 2023
6778b58
use dotnat-format tool for a while
marcin-krystianc Mar 28, 2023
38937b5
asp netcore versions
marcin-krystianc Mar 28, 2023
81f4ac4
fix yaml
marcin-krystianc Mar 28, 2023
e36e346
windows-latest for package
marcin-krystianc Mar 28, 2023
3524dc5
use net7
marcin-krystianc Mar 28, 2023
4912380
Merge branch 'marcink-20230328-ci' into marcink-20230324-locks
marcin-krystianc Mar 28, 2023
5a73d97
Revert "tmp"
marcin-krystianc Mar 28, 2023
ad7a9bd
traces
marcin-krystianc Mar 28, 2023
1af918a
remove unnecessary workflows
marcin-krystianc Mar 28, 2023
9afbcd8
ignore exceptions
marcin-krystianc Mar 28, 2023
95ff6f0
verbosity=detailed
marcin-krystianc Mar 29, 2023
ab05310
remove custom collections - to avoid running tests in parallel
marcin-krystianc Mar 29, 2023
4feffbe
bump
marcin-krystianc Mar 29, 2023
9b25355
bump
marcin-krystianc Mar 29, 2023
6b7c43c
bump
marcin-krystianc Mar 29, 2023
f77e23d
bump
marcin-krystianc Mar 29, 2023
2169720
10x
marcin-krystianc Mar 29, 2023
dca9504
logger console
marcin-krystianc Mar 29, 2023
52059f8
Merge remote-tracking branch 'origin/master' into marcink-20230324-locks
marcin-krystianc Mar 29, 2023
409cbfd
ci
marcin-krystianc Mar 29, 2023
564742a
jsut consul tests
marcin-krystianc Mar 29, 2023
1c91e73
repeat
marcin-krystianc Mar 29, 2023
0b5802d
bump
marcin-krystianc Mar 29, 2023
487ca22
bump
marcin-krystianc Mar 29, 2023
a3f5cf6
bump
marcin-krystianc Mar 29, 2023
3ac439a
bump
marcin-krystianc Mar 29, 2023
d739874
diagnosticMessages
marcin-krystianc Mar 29, 2023
ecc48c7
namespace
marcin-krystianc Mar 30, 2023
c827eb3
using
marcin-krystianc Mar 30, 2023
f7abcc3
parallel
marcin-krystianc Mar 30, 2023
96cf251
15
marcin-krystianc Mar 30, 2023
75b5fd9
Revert "bump"
marcin-krystianc Mar 30, 2023
6d38ee1
revert
marcin-krystianc Mar 30, 2023
9140112
revert
marcin-krystianc Mar 30, 2023
082b4b1
revert
marcin-krystianc Mar 30, 2023
ae3df0f
revert
marcin-krystianc Mar 30, 2023
40f1d7b
less parallel
marcin-krystianc Mar 30, 2023
3722191
bump x8
marcin-krystianc Mar 30, 2023
0d63e53
contenderPool = 50
marcin-krystianc Mar 30, 2023
9d35f11
add logging to locktests too
marcin-krystianc Mar 30, 2023
68033b6
just slow tests
marcin-krystianc Mar 30, 2023
a0da660
fix compilation
marcin-krystianc Mar 30, 2023
d6e4042
no macos
marcin-krystianc Mar 30, 2023
e9922e3
too many cis
marcin-krystianc Mar 30, 2023
ee632fe
upload logs
marcin-krystianc Mar 30, 2023
c83f6c1
MaxParallelThreads = 4
marcin-krystianc Mar 30, 2023
83142f4
MaxParallelThreads = 4
marcin-krystianc Mar 30, 2023
b89ea3f
bump
marcin-krystianc Mar 30, 2023
a37d10d
DefaultConnectionLimit = 10;
marcin-krystianc Mar 30, 2023
a61acc5
ThreadPool.SetMinThreads
marcin-krystianc Mar 30, 2023
6a563cc
int.MaxValue
marcin-krystianc Mar 30, 2023
0d443cf
bump
marcin-krystianc Mar 30, 2023
dbe58f1
bump
marcin-krystianc Mar 30, 2023
6a8fc9b
bump
marcin-krystianc Mar 30, 2023
3f04d5c
bump
marcin-krystianc Mar 30, 2023
3d1be27
bump
marcin-krystianc Mar 30, 2023
2fee583
threadpool back to defaults
marcin-krystianc Mar 30, 2023
6884456
bump
marcin-krystianc Mar 30, 2023
6556437
new Exception($"workerThreads={workerThreads}, completionPortThreads=…
marcin-krystianc Mar 30, 2023
1a0b063
show on all OSs
marcin-krystianc Mar 30, 2023
b37b999
ThreadPool.SetMinThreads(32, 4);
marcin-krystianc Mar 30, 2023
fd6e273
diff noise
marcin-krystianc Mar 30, 2023
8885625
bump min threads only when too low
marcin-krystianc Mar 31, 2023
841600b
Merge remote-tracking branch 'origin/master' into marcink-20230324-locks
marcin-krystianc Mar 31, 2023
ce03359
<
marcin-krystianc Mar 31, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Consul.Test/BaseFixture.cs
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ static BaseFixture()
// but on .NETFramework the default limit is sometimes very low (2) so we need to bump it to higher value.
// E.g. https://github.com/microsoft/referencesource/blob/5697c29004a34d80acdaf5742d7e699022c64ecd/System.Web/HttpRuntime.cs#L1200
ServicePointManager.DefaultConnectionLimit = int.MaxValue;

// As for HTTP connections, we need multiple threads to test semaphores and locks.
// XUnit sets the initial number of worker threads to the number of CPU cores.
// Unfortunately, when the initial limit for the ThreadPool is too low, it introduces a risk of a deadlock-like behavior and the tests are timing out.
ThreadPool.SetMinThreads(32, 4);
}

public BaseFixture()
Expand Down