-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make lock-related tests not flaky #211
Make lock-related tests not flaky #211
Conversation
…{completionPortThreads}");
Wow, interesting find... I see that you used Good job! |
Well, PS: |
FYI, I've checked how many threads are initially created by console applications and it turns out that number is also equal to the number of logical cores. So to avoid creating "too many" threads in the thread pool I've just pushed a change that bumps the number of worker threads only if the initial number is less than 4. |
Fixes #210
After many experiments, I've finally found that flaky lock-related tests were caused by a low initial value of worker threads in the thread pool. It led to deadlock-like scenarios which resulted in expiring sessions due to missed renewal window.