-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private Struct Fields for Blockchain Types #5613
Private Struct Fields for Blockchain Types #5613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, but with these fields now private how would these types be instantiated as constants or configureable constants?
Currently we are able to do:
configurable {
SIGNER: Address = Address {
value: ZERO_B256,
},
}
Initialising with Address::from(ZERO_B256)
would cause the error:
^^^^^^^^^^^^^^^^ Could not evaluate initializer to a const declaration.
What version of forc are you using to test this? I've added tests to add |
I tried it with forc = "0.50.0". If it's working on this PR though it's a non-issue. |
## Description Merges the staging branch into master from the following PRs: #5640 #5630 #5621 #5613 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: IGI-111 <[email protected]> Co-authored-by: Sophie Dankel <[email protected]>
Description
Updates the following blockchain types to have private struct variables:
Address
ContractId
AssetId
Note: This PR merges into a staging branch
Checklist
Breaking*
orNew Feature
labels where relevant.