Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: upgrading forc to 0.55.0 #2045

Merged
merged 87 commits into from
Apr 25, 2024
Merged

Conversation

arboleya
Copy link
Member

@arboleya arboleya commented Apr 11, 2024

Breaking Changes

1) AssetId & EvmAddress

Property value was renamed to bits.

  • Before:

    /**
    * @prop value - A 256 bit hash string with the first 12 bytes cleared
    */
    export type EvmAddress = {
    value: B256AddressEvm;
    };
    /**
    * @prop value - A wrapped 256 bit hash string
    */
    export type AssetId = {
    value: B256Address;
    };

  • After:

    /**
    * @prop bits - A 256 bit hash string with the first 12 bytes cleared
    */
    export type EvmAddress = {
    bits: B256AddressEvm;
    };
    /**
    * @prop bits - A wrapped 256 bit hash string
    */
    export type AssetId = {
    bits: B256Address;
    };

2) Vector

Method encapsulation.

@arboleya arboleya added the chore Issue is a chore label Apr 11, 2024
@arboleya
Copy link
Member Author

Should we wait until sway-libs is compatible with forc 0.52.x before merging this?

@maschad I'm afraid we can't do that. We are already on a tight schedule.

However, if I may guess where your question is coming from, I think @Dhaiwat10 suggested a temporary fix for it.

maschad
maschad previously approved these changes Apr 24, 2024
@maschad
Copy link
Member

maschad commented Apr 24, 2024

Should we wait until sway-libs is compatible with forc 0.52.x before merging this?

@maschad I'm afraid we can't do that. We are already on a tight schedule.

However, if I may guess where your question is coming from, I think @Dhaiwat10 suggested a temporary fix for it.

Thanks for the clarification. I created #2160 as a follow-up.

nedsalk
nedsalk previously approved these changes Apr 25, 2024
Base automatically changed from ps/docs/patch-beta-5-fuels-version to master April 25, 2024 16:49
@petertonysmith94 petertonysmith94 dismissed stale reviews from nedsalk, maschad, Dhaiwat10, Torres-ssf, danielbate, and themself April 25, 2024 16:49

The base branch was changed.

@arboleya arboleya enabled auto-merge (squash) April 25, 2024 17:19
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
79.34%(+0%) 69.3%(+0%) 77.38%(+0%) 79.49%(+0%)
Changed Files:

Coverage values did not change👌.

@arboleya arboleya merged commit 0d75266 into master Apr 25, 2024
17 checks passed
@arboleya arboleya deleted the aa/chore/upgrading-forc-0.53.0 branch April 25, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade forc to 0.55.0
7 participants