Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format release targets output #5608

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Format release targets output #5608

merged 2 commits into from
Feb 14, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Feb 13, 2024

Description

Solves [1] and [2] of #5607

fuel target
image

other targets
image

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review February 13, 2024 22:25
@sdankel sdankel requested a review from a team February 13, 2024 22:26
@sdankel sdankel enabled auto-merge (squash) February 13, 2024 22:34
Copy link

Benchmark for 2d1d17b

Click to view benchmark
Test Base PR %
code_action 5.2±0.10ms 5.2±0.09ms 0.00%
code_lens 332.4±11.23ns 289.9±10.13ns -12.79%
compile 3.0±0.07s 3.1±0.03s +3.33%
completion 4.7±0.10ms 4.8±0.09ms +2.13%
did_change_with_caching 2.8±0.02s 3.0±0.02s +7.14%
document_symbol 970.0±61.79µs 976.3±13.17µs +0.65%
format 91.9±1.42ms 91.9±1.11ms 0.00%
goto_definition 360.3±8.11µs 360.8±6.24µs +0.14%
highlight 8.8±0.15ms 8.9±0.22ms +1.14%
hover 542.4±24.39µs 538.1±8.45µs -0.79%
idents_at_position 122.7±0.39µs 123.4±0.99µs +0.57%
inlay_hints 653.2±19.88µs 707.2±29.71µs +8.27%
on_enter 478.4±9.51ns 491.1±13.25ns +2.65%
parent_decl_at_position 3.6±0.09ms 3.6±0.02ms 0.00%
prepare_rename 358.0±8.05µs 359.6±6.23µs +0.45%
rename 9.1±0.02ms 9.3±0.22ms +2.20%
semantic_tokens 1053.8±33.27µs 1067.1±31.20µs +1.26%
token_at_position 352.4±2.39µs 351.8±2.23µs -0.17%
tokens_at_position 3.6±0.03ms 3.6±0.04ms 0.00%
tokens_for_file 413.8±2.18µs 418.1±6.76µs +1.04%
traverse 38.9±0.90ms 39.5±1.15ms +1.54%

Copy link

Benchmark for d0e7091

Click to view benchmark
Test Base PR %
code_action 5.3±0.03ms 5.3±0.09ms 0.00%
code_lens 334.5±7.67ns 287.3±5.75ns -14.11%
compile 2.9±0.03s 3.0±0.02s +3.45%
completion 4.9±0.08ms 4.9±0.07ms 0.00%
did_change_with_caching 2.8±0.04s 2.9±0.07s +3.57%
document_symbol 958.8±11.17µs 953.7±21.58µs -0.53%
format 88.7±1.15ms 90.8±0.77ms +2.37%
goto_definition 359.9±5.66µs 357.6±5.66µs -0.64%
highlight 9.1±0.01ms 9.1±0.12ms 0.00%
hover 537.0±8.18µs 546.1±9.15µs +1.69%
idents_at_position 121.9±0.46µs 123.9±0.73µs +1.64%
inlay_hints 675.2±9.84µs 675.4±32.07µs +0.03%
on_enter 482.4±14.35ns 490.6±8.69ns +1.70%
parent_decl_at_position 3.7±0.02ms 3.8±0.03ms +2.70%
prepare_rename 364.3±5.58µs 367.1±4.11µs +0.77%
rename 9.4±0.11ms 9.5±0.02ms +1.06%
semantic_tokens 1044.2±13.92µs 1060.3±20.02µs +1.54%
token_at_position 355.7±8.79µs 356.4±2.66µs +0.20%
tokens_at_position 3.7±0.03ms 3.8±0.03ms +2.70%
tokens_for_file 412.5±1.64µs 421.7±2.97µs +2.23%
traverse 37.8±1.18ms 37.2±0.53ms -1.59%

@sdankel sdankel merged commit 304317c into master Feb 14, 2024
33 checks passed
@sdankel sdankel deleted the sophie/forc-target-fmt branch February 14, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants