Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update forc-client for release mode #5607

Closed
sdankel opened this issue Feb 13, 2024 · 0 comments · Fixed by #5609
Closed

Update forc-client for release mode #5607

sdankel opened this issue Feb 13, 2024 · 0 comments · Fixed by #5609
Assignees
@sdankel
Labels
forc-client Everything related to the `forc-client` crate. good first issue Good for newcomers

Comments

@sdankel
Copy link
Member

sdankel commented Feb 13, 2024 •
edited
Loading

  1. We should update the build finished message to look more like cargo:

Finished release [optimized] target(s) in 0.79s
Finished debug [unoptimized] target(s) in 0.79s

image

image
image

  1. The Compiling and contract ... Bytecode size should only show when in verbose mode -v

  2. When code is built from forc deploy, it should alway be built in release mode.

  • should it always, or should it just default to release mode?
@sdankel sdankel added good first issue Good for newcomers forc-client Everything related to the `forc-client` crate. labels Feb 13, 2024
@sdankel sdankel self-assigned this Feb 13, 2024
@sdankel sdankel mentioned this issue Feb 13, 2024
Merged
7 tasks
@sdankel sdankel changed the title Add a forc build debug message Update forc-client for release mode Feb 13, 2024
@sdankel sdankel mentioned this issue Feb 13, 2024
Merged
7 tasks
sdankel added a commit that referenced this issue Feb 14, 2024
@sdankel
Format release targets output (#5608)
304317c 
## Description

Solves [1] and [2] of #5607

fuel target

![image](https://github.com/FuelLabs/sway/assets/47993817/44e4a877-919d-4046-8095-51a5788994c8)

other targets

![image](https://github.com/FuelLabs/sway/assets/47993817/069945a4-be75-4516-a720-a6a8e3c92b73)

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
@FuelLabs FuelLabs deleted a comment from Nar035 Feb 15, 2024
@FuelLabs FuelLabs deleted a comment from Kheiriahmadasl Feb 15, 2024
sdankel added a commit that referenced this issue Feb 17, 2024
@sdankel
Make forc-deploy create release builds by default (#5609)
f8b7431 
## Description

Closes #5607

Solves part [1] of #5607 by
making "release" the default build plan for forc-deploy. It can still be
overridden, i.e. for the test harness.

Other changes:

- removed the `--release` and `--error-on-warnings` options from
forc-deploy, since those aren't needed.
- refactored `BuildProfile` into its own file and added a test, since I
noticed some of the options weren't deserializing

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
@arboleya arboleya mentioned this issue Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdankel sdankel

Labels
forc-client Everything related to the `forc-client` crate. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make forc-deploy create release builds by default FuelLabs/sway
1 participant
@sdankel