Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements associated types #5048

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Implements associated types #5048

merged 5 commits into from
Sep 19, 2023

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Aug 28, 2023

Description

Implements associated types parsing.

Adds associated types to trait map.

Modifies resolve_symbol to handle associated types.

Support was added for type ascription, methods parameters, method return types, and function parameters.

It is still missing fully qualified paths, and checking associated types name conflicts.

It is also missing updating the documentation.

Closes #4487
Closes #610

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@esdrubal esdrubal added compiler General compiler. Should eventually become more specific as the issue is triaged language feature Core language features visible to end users labels Aug 28, 2023
@esdrubal esdrubal self-assigned this Aug 28, 2023
@esdrubal esdrubal force-pushed the esdrubal/associated_types branch 2 times, most recently from c7c9960 to cbe2832 Compare September 11, 2023 11:48
@esdrubal esdrubal requested a review from a team September 11, 2023 14:43
@esdrubal esdrubal marked this pull request as ready for review September 13, 2023 09:07
sway-error/src/error.rs Outdated Show resolved Hide resolved
@IGI-111 IGI-111 requested a review from a team September 13, 2023 12:18
Implements associated types parsing.

Adds associated types to trait map.

Modifies resolve_symbol to handle associated types.
@IGI-111 IGI-111 requested a review from a team September 19, 2023 17:06
@esdrubal esdrubal merged commit d61fc36 into master Sep 19, 2023
31 checks passed
@esdrubal esdrubal deleted the esdrubal/associated_types branch September 19, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler General compiler. Should eventually become more specific as the issue is triaged language feature Core language features visible to end users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support associated types for traits and abis Add associated items to impls and traits.
3 participants