-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements associated types #5048
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esdrubal
added
compiler
General compiler. Should eventually become more specific as the issue is triaged
language feature
Core language features visible to end users
labels
Aug 28, 2023
esdrubal
force-pushed
the
esdrubal/associated_types
branch
2 times, most recently
from
September 11, 2023 11:48
c7c9960
to
cbe2832
Compare
esdrubal
force-pushed
the
esdrubal/associated_types
branch
from
September 13, 2023 08:09
cbe2832
to
7149a7b
Compare
IGI-111
reviewed
Sep 13, 2023
IGI-111
reviewed
Sep 13, 2023
IGI-111
reviewed
Sep 13, 2023
sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs
Outdated
Show resolved
Hide resolved
IGI-111
reviewed
Sep 13, 2023
Implements associated types parsing. Adds associated types to trait map. Modifies resolve_symbol to handle associated types.
esdrubal
force-pushed
the
esdrubal/associated_types
branch
from
September 14, 2023 17:44
7149a7b
to
4d2b108
Compare
tritao
requested changes
Sep 15, 2023
sway-core/src/semantic_analysis/ast_node/declaration/impl_trait.rs
Outdated
Show resolved
Hide resolved
IGI-111
approved these changes
Sep 19, 2023
tritao
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
compiler
General compiler. Should eventually become more specific as the issue is triaged
language feature
Core language features visible to end users
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements associated types parsing.
Adds associated types to trait map.
Modifies resolve_symbol to handle associated types.
Support was added for type ascription, methods parameters, method return types, and function parameters.
It is still missing fully qualified paths, and checking associated types name conflicts.
It is also missing updating the documentation.
Closes #4487
Closes #610
Checklist
Breaking*
orNew Feature
labels where relevant.