Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support associated types for traits and abis #4487

Closed
IGI-111 opened this issue Apr 24, 2023 · 0 comments · Fixed by #5048
Closed

Support associated types for traits and abis #4487

IGI-111 opened this issue Apr 24, 2023 · 0 comments · Fixed by #5048
Assignees
@esdrubal
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser language feature Core language features visible to end users
Milestone
0

Comments

@IGI-111
Copy link
Contributor

IGI-111 commented Apr 24, 2023

We should follow the same conventions as Rust excluding GATs.

This is crucial for many other features including iterators.
@IGI-111 IGI-111 added language feature Core language features visible to end users compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser labels Apr 24, 2023
@IGI-111 IGI-111 mentioned this issue Apr 24, 2023
Closed
2 tasks
@IGI-111 IGI-111 assigned tritao and unassigned tritao May 11, 2023
@IGI-111 IGI-111 added this to the October 2023 milestone Jul 6, 2023
@esdrubal esdrubal mentioned this issue Sep 11, 2023
Merged
7 tasks
esdrubal added a commit that referenced this issue Sep 19, 2023
@esdrubal @IGI-111
Implements associated types (#5048)
d61fc36 
## Description

Implements associated types parsing.

Adds associated types to trait map.

Modifies resolve_symbol to handle associated types.

Support was added for type ascription, methods parameters, method return
types, and function parameters.

It is still missing fully qualified paths, and checking associated types
name conflicts.

It is also missing updating the documentation.

Closes #4487
Closes #610

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: IGI-111 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@esdrubal esdrubal

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser language feature Core language features visible to end users
Projects
None yet
Milestone
0
Development

Successfully merging a pull request may close this issue.

Implements associated types FuelLabs/sway
3 participants
@tritao @esdrubal @IGI-111