Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting conditionals with comments #4936

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Fix formatting conditionals with comments #4936

merged 4 commits into from
Aug 10, 2023

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Aug 9, 2023

Description

Closes #4935

  • In order to write comments for the else block when it only contains a comment, I had to add the span to CodeBlockContents

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review August 9, 2023 22:05
@sdankel
Copy link
Member Author

sdankel commented Aug 9, 2023

I'm not sure why the markdown lint is failing...

@sdankel sdankel requested a review from a team August 9, 2023 22:06
@JoshuaBatty JoshuaBatty requested a review from a team August 10, 2023 00:39
@sdankel sdankel merged commit d1fdd65 into master Aug 10, 2023
@sdankel sdankel deleted the sophie/4935 branch August 10, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment gets deleted inside nested conditional
3 participants