Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment gets deleted inside nested conditional #4935

Closed
sdankel opened this issue Aug 9, 2023 · 0 comments · Fixed by #4936
Closed

Comment gets deleted inside nested conditional #4935

sdankel opened this issue Aug 9, 2023 · 0 comments · Fixed by #4936
Assignees
@sdankel
Labels
bug Something isn't working formatter

Comments

@sdankel
Copy link
Member

sdankel commented Aug 9, 2023

Related #4824

Formatting this code deletes the comment:

fn conditional_with_comment() {
    if true {
        // comment here
    }
}

This results in a panic:

fn conditional_with_comment() {
    if true {
        // if
    } else {
        // else
    }
}
@sdankel sdankel self-assigned this Aug 9, 2023
@sdankel sdankel added bug Something isn't working formatter labels Aug 9, 2023
@sdankel sdankel mentioned this issue Aug 9, 2023
Merged
7 tasks
sdankel added a commit that referenced this issue Aug 10, 2023
@sdankel
Fix formatting conditionals with comments (#4936)
d1fdd65 
## Description

Closes #4935

- In order to write comments for the else block when it only contains a
comment, I had to add the span to `CodeBlockContents`

## Checklist

- [x] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdankel sdankel

Labels
bug Something isn't working formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix formatting conditionals with comments FuelLabs/sway
1 participant
@sdankel