Create uninitialized task for v1 gas price service #2442
Conversation
MitchTurner
changed the base branch from
master
to
feature/allow-DA-blocks-to-be-received-out-of-order
…to feature/init-task-for-v1-gas-price-service
…to feature/init-task-for-v1-gas-price-service
…to feature/init-task-for-v1-gas-price-service
…to feature/init-task-for-v1-gas-price-service
MitchTurner
requested review from
rafal-ch,
xgreenx and
Dentosal
as code owners
| DA: DaBlockCostsSource, | ||
| SettingsProvider: GasPriceSettingsProvider, | ||
| { | ||
| const NAME: &'static str = "GasPriceServiceV0"; |
There was a problem hiding this comment.
| const NAME: &'static str = "GasPriceServiceV0"; | |
| const NAME: &'static str = "GasPriceServiceV1"; |
| pub fn initialize_algorithm<Metadata>( | ||
| config: &V1AlgorithmConfig, | ||
| latest_block_height: u32, | ||
| metadata_storage: &Metadata, | ||
| ) -> GasPriceResult<(AlgorithmUpdaterV1, SharedV1Algorithm)> | ||
| where | ||
| Metadata: MetadataStorage, | ||
| { | ||
| let algorithm_updater; | ||
| if let Some(updater_metadata) = metadata_storage | ||
| .get_metadata(&latest_block_height.into()) | ||
| .map_err(|err| GasPriceError::CouldNotInitUpdater(anyhow::anyhow!(err)))? | ||
| { | ||
| let previous_metadata: V1Metadata = updater_metadata.try_into()?; | ||
| algorithm_updater = v1_algorithm_from_metadata(previous_metadata, config); | ||
| } else { | ||
| algorithm_updater = config.into(); | ||
| } | ||
|
|
||
| let shared_algo = | ||
| SharedGasPriceAlgo::new_with_algorithm(algorithm_updater.algorithm()); | ||
|
|
||
| Ok((algorithm_updater, shared_algo)) | ||
| } |
There was a problem hiding this comment.
i think this is a dupe of initialize_algorithm from the v1/service.rs file, right?
There was a problem hiding this comment.
|
There is also the case where we have unrecorded blocks in the metadata that the committer has already reported. In that case we might want to recursively ask for batches of our smallest heights. The problem is we can't be sure we've got all the correct batches since the lowest height might be skipped. |
| config: V1AlgorithmConfig, | ||
| genesis_block_height: BlockHeight, | ||
| settings: SettingsProvider, | ||
| block_stream: BoxStream<SharedImportResult>, |
There was a problem hiding this comment.
Do we need to box this stream? Can't we just be generic over the stream here to be more flexible for e.g. tests?
| }; | ||
| use fuel_gas_price_algorithm::v1::AlgorithmUpdaterV1; | ||
|
|
||
| pub struct UninitializedTask< |
There was a problem hiding this comment.
I'm not following why we need a separate UninitializedTask. As I read this, the purpose of this type is to separate task creation (UninitializedTask::new) and initialization UninitializedTask::init. I don't see any extra information being provided during initialization, so what's the benefit of doing this over having a single function that returns GasPriceServiceV1 directly?
There was a problem hiding this comment.
Summary: The initialization logic depends on database concepts (getting blocks at different heights etc.) that we don't want the gas price algo to be aware of, to maintain a good separation between domain and integration logic. Ideally this initialization logic shouldn't even be here but rather closer to the fuel-core code that starts the services, but for the time being it's better to keep it isolated to this particular task.
…to feature/init-task-for-v1-gas-price-service
| let start = read_algo.next_gas_price(); | ||
| let mut watcher = StateWatcher::started(); |
There was a problem hiding this comment.
is there a reason this isn't StateWatcher::default()?
Linked Issues/PRs
part of #2140
Description
Adding the
UninitializedTaskwith minimum test coverage.Because of how we are organizing #2415, I don't believe we need to do any syncing of the DA Cost service before startup. If it's "behind" somehow, then the old values it provides will just be ignored. It might result in a little error in the profit value early on, but it will get washed out pretty quickly.
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]