-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade fuel core to use V1 gas price algo/updater #2140
Comments
9 tasks
We have some versioning going on with the algorithm:
I don't think we need that. I think we can just depend on a single algorithm and change it as we improve it. Shouldn't be a problem. |
assigning to myself |
9 tasks
rymnc
added a commit
that referenced
this issue
Nov 14, 2024
…#2416) > [!NOTE] > Some values for the tests need expert opinion from @MitchTurner. A follow up PR will be created to define the `UninitializedTask` that wraps over this task. ## Linked Issues/PRs <!-- List of related issues/PRs --> part of #2140, but doesn't close it yet. ## Description <!-- List of detailed changes --> - We define a new `RunnableTask`, `GasPriceServiceV1`, which uses the da block cost source in tandem with the l2 block source - Tests for the same - Casts to and from the v1 algorithm updater - we take a direct dependency on v0's metadata so that we can migrate between the two. ## Checklist - [x] Breaking changes are clearly marked as such in the PR description and changelog - [x] New behavior is reflected in tests - [x] [The specification](https://github.com/FuelLabs/fuel-specs/) matches the implemented behavior (link update PR if changes are needed) ### Before requesting review - [x] I have reviewed the code myself - [ ] I have created follow-up issues caused by this PR and linked them here ### After merging, notify other teams [Add or remove entries as needed] - [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/) - [ ] [Sway compiler](https://github.com/FuelLabs/sway/) - [ ] [Platform documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+) (for out-of-organization contributors, the person merging the PR will do this) - [ ] Someone else?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This includes adding the config values once it is fully integrated.
It's not clear to me how we want to smoothly transition the values. We should probably start taking the DA costs into calculation, but configure it to always have DA costs as 0 until we get some good tests up.
The text was updated successfully, but these errors were encountered: