Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom builds #183

Merged
merged 5 commits into from
Apr 15, 2019
Merged

Add support for custom builds #183

merged 5 commits into from
Apr 15, 2019

Conversation

TomaszGasior
Copy link
Contributor

@TomaszGasior TomaszGasior commented Apr 13, 2019

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #180
License MIT

This PR adds support for custom builds from https://ckeditor.com/cke4/builder to ckeditor:install console command. Usage:

bin/console ckeditor:install --release=custom --custom-build-id=574a82a0d3e9226d94b0e91d10eaa372

To use this feature go to https://ckeditor.com/cke4/builder, generate your own build, download it and get your custom build ID from build-config.js file.

TomaszGasior added a commit to TomaszGasior/RadioLista-v3 that referenced this pull request Apr 14, 2019
This commit depends on this pull request:
FriendsOfSymfony/FOSCKEditorBundle#183
TomaszGasior added a commit to TomaszGasior/RadioLista-v3 that referenced this pull request Apr 14, 2019
This commit depends on this pull request:
FriendsOfSymfony/FOSCKEditorBundle#183
TomaszGasior added a commit to TomaszGasior/RadioLista-v3 that referenced this pull request Apr 14, 2019
This commit depends on this pull request:
FriendsOfSymfony/FOSCKEditorBundle#183
Do not rely on ZIP archive list to create directories. Some ZIP archive doesn't list
folders directly. It's safier to skip directories from list and create it manually
when it's needed.

This is needed for ZIP archives generated from CKEditor website.
@kunicmarko20
Copy link
Contributor

@ElectricMaxxx got time to review or should I just merge it?

@kunicmarko20 kunicmarko20 merged commit 7ba7873 into FriendsOfSymfony:2.x Apr 15, 2019
@kunicmarko20
Copy link
Contributor

Thank you @TomaszGasior!

TomaszGasior added a commit to TomaszGasior/RadioLista-v3 that referenced this pull request Apr 17, 2019
This commit depends on this pull request:
FriendsOfSymfony/FOSCKEditorBundle#183
@kunicmarko20
Copy link
Contributor

https://github.com/FriendsOfSymfony/FOSCKEditorBundle/releases/tag/2.1.0 just tagged 2.1

@mattchete
Copy link
Contributor

mattchete commented Feb 10, 2020

Hi and thanks for this great feature :)
Do you know the best way to integrate this call in a deploy ?
Right now I have added a post-install-cmd in composer.json to a scriptHandler function I created :

<?php

namespace AppBundle\Composer;

use Composer\Script\Event;

class ScriptHandler extends \Sensio\Bundle\DistributionBundle\Composer\ScriptHandler {

    public static function ckEditorInstall(Event $event)
    {
        $options = self::getOptions($event);
        $consoleDir = self::getConsoleDir($event, 'CkEditor install');

        if (null === $consoleDir) {
            return;
        }

        static::executeCommand($event, $consoleDir, 'ckeditor:install --release=custom --custom-build-id=58d0f97187c76c2b113d525a9bc9819e --no-progress-bar --clear=drop', $options['process-timeout']);
    }

}

Is there any better way ? Or do who have to upgrade FOSCKEditorBundle to take into account config for that ?

Thanks :)

@TomaszGasior
Copy link
Contributor Author

@mattchete
Copy link
Contributor

Yeah I've seen that but i'm on sf3.
I just found that from the previous version, I guess that's the solution for now:
https://github.com/FriendsOfSymfony/FOSCKEditorBundle/pull/152/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants