-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom builds #183
Add support for custom builds #183
Conversation
This commit depends on this pull request: FriendsOfSymfony/FOSCKEditorBundle#183
This commit depends on this pull request: FriendsOfSymfony/FOSCKEditorBundle#183
This commit depends on this pull request: FriendsOfSymfony/FOSCKEditorBundle#183
Do not rely on ZIP archive list to create directories. Some ZIP archive doesn't list folders directly. It's safier to skip directories from list and create it manually when it's needed. This is needed for ZIP archives generated from CKEditor website.
@ElectricMaxxx got time to review or should I just merge it? |
Thank you @TomaszGasior! |
This commit depends on this pull request: FriendsOfSymfony/FOSCKEditorBundle#183
Hi and thanks for this great feature :) <?php
namespace AppBundle\Composer;
use Composer\Script\Event;
class ScriptHandler extends \Sensio\Bundle\DistributionBundle\Composer\ScriptHandler {
public static function ckEditorInstall(Event $event)
{
$options = self::getOptions($event);
$consoleDir = self::getConsoleDir($event, 'CkEditor install');
if (null === $consoleDir) {
return;
}
static::executeCommand($event, $consoleDir, 'ckeditor:install --release=custom --custom-build-id=58d0f97187c76c2b113d525a9bc9819e --no-progress-bar --clear=drop', $options['process-timeout']);
}
} Is there any better way ? Or do who have to upgrade FOSCKEditorBundle to take into account config for that ? Thanks :) |
Yeah I've seen that but i'm on sf3. |
This PR adds support for custom builds from https://ckeditor.com/cke4/builder to ckeditor:install console command. Usage:
To use this feature go to https://ckeditor.com/cke4/builder, generate your own build, download it and get your custom build ID from build-config.js file.