Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom builds in ckeditor:install #180

Closed
TomaszGasior opened this issue Mar 30, 2019 · 1 comment
Closed

Support for custom builds in ckeditor:install #180

TomaszGasior opened this issue Mar 30, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@TomaszGasior
Copy link
Contributor

Feature Request

Currently ckeditor:install console command supports downloading prebuild official releases — basic, standard and full. I would suggest to support also custom builds which are generated by CKEditor website.

Each custom build has its own ID which can be used as part of URL. For example, my own custom build generated on official ckeditor website has ID 5af1ea2fd3c9442ab08af09ec2423ce6 and it's possible to download it using this URL: http://ckeditor.com/builder/download/5af1ea2fd3c9442ab08af09ec2423ce6 Information about this feature (and build ID) is placed inside build-config.js file in generated archive.

From user perspective this can be implemented by adding to ckeditor:install command new option called --build with build ID as value. Of course, --build and --release could not be used at the same time.

@kunicmarko20
Copy link
Contributor

I would rather add a new release option custom and a new option custom_build_id and then:

$url = sprintf(self::$archive, $options['release'], $options['version']);

here check if it is a custom build, and if the id is not set, throw an exception.

Would you be interested in contributing this feature?

@kunicmarko20 kunicmarko20 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants