Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use word-break on live chat error message #6327

Conversation

ChunkyProgrammer
Copy link
Member

Use word-break on live chat error message

Pull Request Type

  • Bugfix

Related issue

closes #6312

Description

Adds missing word-break for live chat error message

Screenshots

image

Testing

I tested by doing the following:

  • go to lofi girl live stream
  • make sure the chat loads
  • turn off wifi (this adds an error message but the error message isn't that long)
  • inspect element on the error message and update the text to make it longer (this is the text I used: TypeError: This is a longer error message with httpswwwyoutubecomapi/youtubei/v1/v2/msdjhsdksdhshdjsdgshjdsdhsjkdnsdhjskdshdjksdhsjdkjshdskdhsidkshdusikdsjudiskdsdsdgfgfgf error code 200 success )

Desktop

  • OS: Fedora
  • OS Version: 41
  • FreeTube version: 0.22.0 (latest nightly)

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 9, 2024 16:14
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 9, 2024
@FreeTubeBot FreeTubeBot merged commit 5f25890 into FreeTubeApp:development Dec 9, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 9, 2024
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Dec 10, 2024
* development: (96 commits)
  Move Invidious API calls into Invidious file (FreeTubeApp#6313)
  Translated using Weblate (Spanish)
  Use word-break on live chat error message (FreeTubeApp#6327)
  Bump youtubei.js from 11.0.1 to 12.0.0 (FreeTubeApp#6323)
  Bump shaka-player from 4.12.3 to 4.12.4 (FreeTubeApp#6318)
  Make seekbar and player controls appear at bottom of video and take full width (FreeTubeApp#6007)
  Fix 'Object has been destroyed' when FreeTube is passed a URL with no windows open on macOS (FreeTubeApp#6278)
  Bump mikefarah/yq from 4.44.5 to 4.44.6 (FreeTubeApp#6324)
  Translated using Weblate (French)
  Bump sass-loader from 16.0.3 to 16.0.4 (FreeTubeApp#6319)
  Bump webpack from 5.96.1 to 5.97.1 (FreeTubeApp#6322)
  Bump sass from 1.81.0 to 1.82.0 (FreeTubeApp#6320)
  Bump lefthook from 1.8.5 to 1.9.0 (FreeTubeApp#6321)
  Bump @intlify/eslint-plugin-vue-i18n from 3.1.0 to 3.2.0 (FreeTubeApp#6317)
  Translated using Weblate (Estonian)
  Translated using Weblate (Basque)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Hungarian)
  Translated using Weblate (German)
  Fix channel home page list view (FreeTubeApp#6316)
  ...
@ChunkyProgrammer ChunkyProgrammer deleted the use-word-break-on-live-chat-error-mesage branch December 27, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Live chat error overflow
5 participants