Move Invidious API calls into Invidious file #6313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
Is the last error in the console relevant to this PR? I cant seem to reproduce it in the latest nightly. VirtualBoxVM_0PXhdSZCh7.mp4 |
|
@efb4f5ff-1298-471a-8973-3d47447115dc seems to be a bug with invidious/that instance. |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Dec 9, 2024
|
I still got error with |
|
@PikachuEXE |
Co-authored-by: ChunkyProgrammer <[email protected]>
absidue
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
ChunkyProgrammer
approved these changes
Dec 9, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 9, 2024
PikachuEXE
approved these changes
Dec 10, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Dec 10, 2024
* development: (96 commits) Move Invidious API calls into Invidious file (FreeTubeApp#6313) Translated using Weblate (Spanish) Use word-break on live chat error message (FreeTubeApp#6327) Bump youtubei.js from 11.0.1 to 12.0.0 (FreeTubeApp#6323) Bump shaka-player from 4.12.3 to 4.12.4 (FreeTubeApp#6318) Make seekbar and player controls appear at bottom of video and take full width (FreeTubeApp#6007) Fix 'Object has been destroyed' when FreeTube is passed a URL with no windows open on macOS (FreeTubeApp#6278) Bump mikefarah/yq from 4.44.5 to 4.44.6 (FreeTubeApp#6324) Translated using Weblate (French) Bump sass-loader from 16.0.3 to 16.0.4 (FreeTubeApp#6319) Bump webpack from 5.96.1 to 5.97.1 (FreeTubeApp#6322) Bump sass from 1.81.0 to 1.82.0 (FreeTubeApp#6320) Bump lefthook from 1.8.5 to 1.9.0 (FreeTubeApp#6321) Bump @intlify/eslint-plugin-vue-i18n from 3.1.0 to 3.2.0 (FreeTubeApp#6317) Translated using Weblate (Estonian) Translated using Weblate (Basque) Translated using Weblate (Icelandic) Translated using Weblate (Hungarian) Translated using Weblate (German) Fix channel home page list view (FreeTubeApp#6316) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Invidious API calls into Invidious file
Pull Request Type
Description
This pull request moves the Invidious API calls into the Invidious file. That reduces the code inside the components themselves and also hides some of the implemenation details, such as parsing the published dates, making for a cleaner API. As an added benefit this also reduces code duplication between the channel and subscription pages.
Testing
Please test all parts of the app that make API calls with the Invidious API
Desktop