Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app menu to add item for preferences #2777

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Update app menu to add item for preferences #2777

merged 1 commit into from
Oct 29, 2022

Conversation

PikachuEXE
Copy link
Collaborator

Update app menu to add item for preferences

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

#1869 Partially

Description

Update app menu to add item for preferences
with keyboard shortcut

Screenshots

Screen.Recording.2022-10-27.at.11.07.08.mov

Testing

  • Use new menu item to navigate to settings view
  • Use new keyboard shortcut (Ctrl/Cmd + ,) to navigate to settings view

Desktop

  • OS: MacOS
  • OS Version: 12.6
  • FreeTube version: 64679ca

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 27, 2022 03:08
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 27, 2022
absidue
absidue approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both the shortcut and the menu item and they worked

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could u add this shortcut to the docs? :)

@FreeTubeBot FreeTubeBot merged commit 31938d9 into FreeTubeApp:development Oct 29, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 29, 2022
@PikachuEXE PikachuEXE deleted the feature/shortcuts/settings branch October 30, 2022 00:25
@PikachuEXE PikachuEXE mentioned this pull request Oct 30, 2022
Merged
@PikachuEXE
Copy link
Collaborator Author

@efb4f5ff-1298-471a-8973-3d47447115dc
FreeTubeApp/FreeTube-Docs#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot