Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MacOS] Extended shortcuts #1869

Open
lothar-cell opened this issue Nov 3, 2021 · 12 comments
Open

[MacOS] Extended shortcuts #1869

lothar-cell opened this issue Nov 3, 2021 · 12 comments
Labels
enhancement New feature or request OS: macos All issues related to Macs, as we do not have one to test things

Comments

@lothar-cell
Copy link

lothar-cell commented Nov 3, 2021

Is your feature request related to a usage problem (not a bug)? Please describe.
More shortcuts would be great, because shortcuts are a good thing.

Describe the solution you'd like to see implemented
Would be great if commands like:

  • New Page (⌘N)
  • New Tab (⌘T)
  • Show Previous/Next Tab
  • Settings (⌘,)
  • History (⌘Y)
  • Home
  • Back, Forward
  • Subscriptions
  • Playlists
  • Switch Channel

and so on would be implemented, they would be menu titles, so they could be customised in OS settings as well.

Screenshots
Screenshot 2021-11-03 at 7 53 18

Shortcut customisation in OS, needs a menu title:
Screenshot 2021-11-03 at 7 55 17

Additional context
no additional context.

@lothar-cell lothar-cell added the enhancement New feature or request label Nov 3, 2021
@ChunkyProgrammer ChunkyProgrammer added the OS: macos All issues related to Macs, as we do not have one to test things label Nov 3, 2021
@efb4f5ff-1298-471a-8973-3d47447115dc

This comment has been minimized.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added U: duplicate This issue or pull request already exists and removed OS: macos All issues related to Macs, as we do not have one to test things labels Nov 3, 2021
@lothar-cell

This comment has been minimized.

@efb4f5ff-1298-471a-8973-3d47447115dc

This comment has been minimized.

@PikachuEXE

This comment has been minimized.

@PikachuEXE PikachuEXE removed the U: duplicate This issue or pull request already exists label Nov 4, 2021
@PikachuEXE PikachuEXE reopened this Nov 4, 2021
@lothar-cell

This comment has been minimized.

@ChunkyProgrammer ChunkyProgrammer added the OS: macos All issues related to Macs, as we do not have one to test things label Nov 5, 2021
@lothar-cell
Copy link
Author

However I have no idea how "menu titles" can be implemented.

Maybe this can be of help? https://stackoverflow.com/questions/38208469/electron-osx-application-menu-how-to-add-custom-file-menu

@PikachuEXE
Copy link
Collaborator

Create first PR for this: #2306

@PikachuEXE
Copy link
Collaborator

PikachuEXE commented Dec 8, 2022

@lothar-cell
What is Switch Channel? Do you mean Channels?

Do you also want Trending, Most Popular, what else...

Edit 1: Just realize Home should be the same as Subscriptions

@lothar-cell
Copy link
Author

lothar-cell commented Dec 8, 2022

@PikachuEXE Yes, I meant switching YouTube Channels, but also switching between Profiles would be nice.
About Trending, Most Popular and Subscriptions, I think the best would be to have an option in settings for choosing what to assign Home to, like in case of Invidious or Piped.

@absidue
Copy link
Member

absidue commented Nov 14, 2023

Changing between subscribed channels is not possible to implement, as the top menu is app-wide in Electron, which means it's the same one across all windows. As FreeTube lets you have different profiles active in different windows, you would need different menus for every window for that to work, but that is something that Electron doesn't support.

@PikachuEXE
Copy link
Collaborator

@absidue I think that point is invalid for "switching profiles" (ya I know he said Switch Channel but I think he meant profile)
If you open multiple windows and use one of the menu items on top, the page will only be changed for the "active window"

See linked PRs for code and see following doc for browser window
https://www.electronjs.org/docs/latest/api/menu-item

I only think change for switching profile in menu item might not accepted coz there can be many profiles
#2965 (comment)
image

@lothar-cell
Copy link
Author

Actually by Switching Channels I meant a shortcut for cycling them, but that was when I had fewer subscriptions. Nevertheless the same thing would even be better for Profiles IMO.
My reason is that the only profile I'm using currently is All Channels, because it's not intuitive switch between them, even though it's a really good idea for organising content. Apart from a shortcut of some sort (cycling / bringing up the profile switcher window / individual shortcuts), an option for setting default profile when launching FreeTube, would help to make it more user-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OS: macos All issues related to Macs, as we do not have one to test things
Projects
Status: To assign
Development

No branches or pull requests

5 participants