Fixing issue with visibleDataList holding onto stale data #2601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue with visibleDataList holding onto stale data
Pull Request Type
Please select what type of pull request this is:
Description
This PR intends to fix an unintentional bug introduced by #2567.
When selecting an invidious instance in the settings, the dropdown which displays possible instances will only update when the view is mounted. The result is that you can not get the dropdown to populate with invidious instances other than the current instance at the time the view was mounted:
The core issue is that the call to
updateVisibleDataList
was moved out ofhandleInput
and into the watch method fordataList
; however, there was no watch method addedinputData
, This means thatvisibleDataList
sometimes retains stale data when it should be updating. This PR aims to resolve this by addingupdateVisibleDataList
to a watch method forinputData
.Screenshots
Testing (for code that is not small enough to be easily understandable)
I have tested the search suggestions and the invidious instance selector, but there may be other relevant
ft-input
s to test.Desktop (please complete the following information):