Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2512: Update search suggestions on input #2567

Merged
merged 2 commits into from
Sep 13, 2022
Merged

#2512: Update search suggestions on input #2567

merged 2 commits into from
Sep 13, 2022

Conversation

malik-steinert
Copy link
Contributor


#2512: Update search suggestions on input

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue
closes #2512

Description
I added a watcher to the input component so that this.updateVisibleDataList() is triggered when the dataList prop changes.

Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@PrestonN PrestonN merged commit c1ff658 into FreeTubeApp:development Sep 13, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 13, 2022
@malik-steinert
Copy link
Contributor Author

Thanks again <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Search suggestions of the previous search are shown if typing one letter in the search bar
5 participants