Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForgeRock Android SDK 4.1.0 Release #302

Merged
merged 34 commits into from
Aug 1, 2023
Merged

ForgeRock Android SDK 4.1.0 Release #302

merged 34 commits into from
Aug 1, 2023

Conversation

spetrov
Copy link
Contributor

@spetrov spetrov commented Jul 31, 2023

JIRA Ticket

SDKS-2596 ForgeRock Android SDK 4.1.0 Release

witrisna and others added 30 commits May 24, 2023 09:13
- Refactor related classed from Java to Kotlin
- Change org.forgerock.android.auth.interceptor.AdviceHandler#onAdviceReceived from returning Future to Suspend function
- Handle header response instead of redirect from IG
- Update sample App to test IG Transaction authorization
ForgeRock Android SDK 4.1.0-beta1 Release
SDKS-2240 Process IG Policy Advice as JSON
…eptor

Add Interceptor support for PUSH_REGISTER and PUSH_AUTHENTICATE Action types
SDKS-2567 - Force token refresh
ForgeRock Android SDK 4.1.0-beta2 release preparation
[SDKS-2458] Dependabot condfiguration
Combined MFA should throw DuplicatedMechanismException
SDKS-2617 Revoke old access token upon force refresh
Upgrading some dependency libraries to fix security issues in sample apps
Fixed permissions in ci.yaml for dependabot.
Fix CI permissions for GITHUB_TOKEN
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 31, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

getAdviceHandler(advice)
.onAdviceReceived(InitProvider.getCurrentActivity(), advice)
}
} catch (e: Exception) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8% of developers fix this issue

TooGenericExceptionCaught: The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.

❗❗ 3 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding
File Path Line Number
forgerock-auth/src/main/java/org/forgerock/android/auth/interceptor/IdentityGatewayAdviceInterceptor.kt 49
forgerock-auth/src/main/java/org/forgerock/android/auth/interceptor/IdentityGatewayAdviceInterceptor.kt 93
forgerock-core/src/main/java/org/forgerock/android/auth/EncryptedSharedPreferences.kt 68

Visit the Lift Web Console to find more details in your report.


ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage
@sonatype-lift ignore Leave out the above finding from this PR
@sonatype-lift ignoreall Leave out all the existing findings from this PR
@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.

@spetrov spetrov requested a review from witrisna August 1, 2023 18:08
@spetrov spetrov merged commit cc9c81c into master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants