-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDKS-2617 Revoke old access token upon force refresh #289
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
forgerock-auth/src/main/java/org/forgerock/android/auth/DefaultTokenManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good , just a minor comment
forgerock-auth/src/main/java/org/forgerock/android/auth/OAuth2Client.java
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/OAuth2Client.java
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/SessionManager.java
Show resolved
Hide resolved
forgerock-auth/src/main/java/org/forgerock/android/auth/TokenManager.java
Show resolved
Hide resolved
forgerock-auth/src/test/java/org/forgerock/android/auth/DefaultTokenManagerTest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes looks good to me. Minor comments to be reviewed
41bd283
to
59c013b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍🏻
JIRA Ticket
https://bugster.forgerock.org/jira/browse/SDKS-2617
Description
Revoke old access token upon force refresh