ForgeRock Android SDK 4.0.0 Release #264
Conversation
Device Binding / Verifier feature - SDKS-1747, SDKS-2022
SDKS-1747 / SDKS-2022 - DeviceBinding/Verifier
… to run the tests against AM instance which has the DeviceBinding node
SDKS-1749 Device Binding QA
SDKS-2143 Add expiration time to JWS for Device Binding and Device Signing Verifier
SDKS-2025 JWS Verifier QA
…s not exist in AM
…estation None when server does not provide the attestation attribute.
SDKS-2413 Android Key Attestation Implementation - Set default to Attestation None when server does not provide the attestation attribute.
SDKS-2446 Error deserializing Account object
SDKS-2437 Device Binding Application Id and Key Attestation e2e Tests
fixed review comments
…orkCollector SDKS-2445_Updates to NetworkCollector
SDKS-2468 Combined MFA Registration issue with non-default Issuer
SDKS-2450 Key Attestation will not support API Level 23
SDKS-2369 Publish SNAPSHOT Release
SDKS-2511 Use single master key for Application Pin encryption
…owedError, simulate as cancelling WebAuthn Authentication.
SDKS-2509 Cancelling WebAuthn Key Selection dialog result with NotAllowedError, simulate as canceling WebAuthn Authentication.
ForgeRock Android SDK 4.0.0 release preparation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| next() | ||
| } catch (e: CancellationException) { | ||
| //ignore | ||
| } catch (e: Exception) { |
There was a problem hiding this comment.
TooGenericExceptionCaught: The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.
❗❗ 23 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| forgerock-auth-ui/src/main/java/org/forgerock/android/auth/ui/callback/DeviceSigningVerifierCallbackFragment.kt | 45 |
| forgerock-auth-ui/src/main/java/org/forgerock/android/auth/ui/callback/WebAuthnAuthenticationCallbackFragment.kt | 44 |
| forgerock-auth-ui/src/main/java/org/forgerock/android/auth/ui/callback/WebAuthnRegistrationCallbackFragment.kt | 47 |
| forgerock-auth/src/main/java/org/forgerock/android/auth/RemoteDeviceBindingRepository.kt | 70 |
| forgerock-auth/src/main/java/org/forgerock/android/auth/WebAuthnDataRepository.kt | 40 |
| forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceBindingCallback.kt | 180 |
| forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceBindingCallback.kt | 259 |
| forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceSigningVerifierCallback.kt | 147 |
| forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceSigningVerifierCallback.kt | 206 |
| forgerock-auth/src/main/java/org/forgerock/android/auth/callback/WebAuthnAuthenticationCallback.kt | 59 |
Showing 10 of 23 findings. Visit the Lift Web Console to see all.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| val hash: ByteArray? = digest.digest(keyName.toByteArray()) | ||
| Base64.encodeToString(hash, Base64.NO_WRAP or Base64.NO_PADDING or Base64.URL_SAFE) | ||
| } catch (e: NoSuchAlgorithmException) { | ||
| throw RuntimeException(e) |
There was a problem hiding this comment.
TooGenericExceptionThrown: RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
| } catch (e: NoSuchAlgorithmException) { | ||
| throw RuntimeException(e) | ||
| } catch (e: Exception) { | ||
| throw RuntimeException(e) |
There was a problem hiding this comment.
TooGenericExceptionThrown: RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
JIRA Ticket
SDKS-2516 ForgeRock Android SDK 4.0.0 Release