SDKS-1747 / SDKS-2022 - DeviceBinding/Verifier - Do not merge to develop #184

jeyanthanperiyasamy · 2022-08-10T03:32:36Z

JIRA Ticket

Please link jira ticket here

Description

Briefly describe the change and any information that would help speedup the review and testing.

Definition of Done Checklist:

sonatype-lift · 2022-08-10T03:42:55Z

forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceBindingCallback.kt

+                keyCallBack =  keyAware.generateKeys(context, it)
+            }
+        }
+        catch (e: Exception) {


TooGenericExceptionCaught: Caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-10T03:42:56Z

forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceBindingCallback.kt

+                                setDeviceName("jan device")
+                                setJws(jws)
+                                Listener.onSuccess(listener, null)
+                            } catch (e: Exception) {


TooGenericExceptionCaught: Caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-10T03:42:57Z

forgerock-auth/src/main/java/org/forgerock/android/auth/devicebind/KeyAware.kt

+                jsonObject.put("userId", userId)
+                jsonObject.put("kid", uuid)
+            } catch (e: JSONException) {
+                throw RuntimeException(e)


TooGenericExceptionThrown: RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-10T03:42:58Z

forgerock-auth/src/main/java/org/forgerock/android/auth/devicebind/KeyAware.kt

+            val hash: ByteArray? = digest.digest(value.toByteArray())
+            Base64.encodeToString(hash, Base64.DEFAULT)
+        } catch (e: NoSuchAlgorithmException) {
+            throw RuntimeException(e)


TooGenericExceptionThrown: RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-11T00:04:05Z

forgerock-auth/src/main/java/org/forgerock/android/auth/devicebind/PreferenceUtil.kt

+              jsonObject.put("userId", userId)
+              jsonObject.put("kid", uuid)
+          } catch (e: JSONException) {
+              throw RuntimeException(e)


TooGenericExceptionThrown: RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-15T15:45:49Z

forgerock-auth/src/main/java/org/forgerock/android/auth/devicebind/KeyAware.kt

+        } catch (e: NoSuchAlgorithmException) {
+            throw RuntimeException(e)
+        }
+        catch (e: Exception) {


TooGenericExceptionCaught: Caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceBindingCallback.kt

witrisna · 2022-08-16T18:49:04Z

forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceBindingCallback.kt

+             listener: FRListener<Void>,
+             keyAware: KeyAwareInterface = KeyAware(userId),
+             encryptedPreference: PreferenceUtil = PreferenceUtil(),
+             executorService: ScheduledExecutorService? = Executors.newSingleThreadScheduledExecutor(),


Instead of using ExecutorService, will it be easier if we just use some calculation with currenttime and timeout?

done, made it even easier

forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceBindingCallback.kt

forgerock-auth/src/main/java/org/forgerock/android/auth/devicebind/BiometricUtil.kt

forgerock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceBindingCallback.kt

sonatype-lift · 2022-08-25T00:16:37Z

...uth/src/main/java/org/forgerock/android/auth/devicebind/SharedPreferencesDeviceRepository.kt

+                jsonObject.put("kid", uuid)
+                jsonObject.put("authType", authenticationType.serializedValue)
+            } catch (e: JSONException) {
+                throw RuntimeException(e)


TooGenericExceptionThrown: RuntimeException is a too generic Exception. Prefer throwing specific exceptions that indicate a specific error case.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

forgerock-auth/src/main/java/org/forgerock/android/auth/devicebind/DeviceBindAuthenticators.kt

spetrov

Overall everything looks good to me!
My only ask is to please add java docs to public interfaces. Currently, the docs are not consistent - e.g. in some places function parameters include description of the params, and return values, etc... and in others these a missing...

forgerock-auth/src/main/java/org/forgerock/android/auth/DeviceIdentifier.java

forgerock-auth/src/main/java/org/forgerock/android/auth/callback/AbstractCallback.java

forgerock-auth/src/main/java/org/forgerock/android/auth/devicebind/BiometricBindingHandler.kt

Device Binding / Verifier feature - SDKS-1747, SDKS-2022

sonatype-lift · 2022-09-16T17:18:42Z

...rock-auth/src/main/java/org/forgerock/android/auth/callback/DeviceSigningVerifierCallback.kt

+                }
+            }
+        }
+        catch (e: Exception) {


TooGenericExceptionCaught: Caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

spetrov

👍🏻

sonatype-lift bot reviewed Aug 10, 2022

View reviewed changes

jeyanthanperiyasamy force-pushed the SDKS-1747-DeviceBind branch from 094e7ca to 8cfc6b7 Compare August 10, 2022 23:54

sonatype-lift bot reviewed Aug 11, 2022

View reviewed changes

jeyanthanperiyasamy force-pushed the SDKS-1747-DeviceBind branch 2 times, most recently from 4dcfd17 to 079d921 Compare August 15, 2022 15:35

sonatype-lift bot reviewed Aug 15, 2022

View reviewed changes

jeyanthanperiyasamy force-pushed the SDKS-1747-DeviceBind branch 5 times, most recently from 7d76290 to 3720dc3 Compare August 16, 2022 06:23

jeyanthanperiyasamy requested a review from witrisna August 16, 2022 06:26

jeyanthanperiyasamy force-pushed the SDKS-1747-DeviceBind branch 3 times, most recently from 54a850d to 3c38c07 Compare August 16, 2022 14:55

witrisna reviewed Aug 16, 2022

View reviewed changes

forgerock-auth/src/main/java/org/forgerock/android/auth/devicebind/BiometricUtil.kt Outdated Show resolved Hide resolved

jeyanthanperiyasamy force-pushed the SDKS-1747-DeviceBind branch 8 times, most recently from 341147f to 3db7b89 Compare August 18, 2022 06:05

Device Bind feature

edda2dd

witrisna reviewed Aug 18, 2022

View reviewed changes

sonatype-lift bot reviewed Aug 25, 2022

View reviewed changes

Refactor

3f51bc1

jeyanthanperiyasamy force-pushed the SDKS-1747-DeviceBind branch 4 times, most recently from 05ecf86 to 6b5b1ac Compare August 25, 2022 14:20

witrisna reviewed Aug 25, 2022

View reviewed changes

forgerock-auth/src/main/java/org/forgerock/android/auth/devicebind/DeviceBindAuthenticators.kt Outdated Show resolved Hide resolved

jeyanthanperiyasamy force-pushed the SDKS-1747-DeviceBind branch from 6b5b1ac to 729ff99 Compare August 25, 2022 17:05

spetrov requested changes Aug 25, 2022

View reviewed changes

merge

93758f3

jeyanthanperiyasamy force-pushed the SDKS-1747-DeviceBind branch from 729ff99 to 93758f3 Compare August 26, 2022 06:04

spetrov previously approved these changes Aug 26, 2022

View reviewed changes

jeyanthanperiyasamy added 4 commits August 29, 2022 14:17

Merge branch 'develop' into SDKS-1747-DeviceBind

f405be5

device verifier feature

b37faae

merge

c7d0de4

merge develop in to bind

c7aa465

jeyanthanperiyasamy dismissed spetrov’s stale review via c7aa465 September 12, 2022 17:37

jeyanthanperiyasamy and others added 6 commits September 14, 2022 01:57

merge

8b367b8

Merge branch 'develop' into SDKS-1747-DeviceBind

e2be3c8

ForgeRock Android SDK 3.3.4 Release preparation

6392cef

Merge branch 'develop' into SDKS-2022

2c9acca

merge 2103 release candidate

e539ac4

Merge pull request #193 from ForgeRock/SDKS-2022

faff6c6

Device Binding / Verifier feature - SDKS-1747, SDKS-2022

jeyanthanperiyasamy changed the title ~~SDKS-1747 - DeviceBinding~~ SDKS-1747 / SDKS-2022 - DeviceBinding Device Binding Sep 16, 2022

jeyanthanperiyasamy changed the title ~~SDKS-1747 / SDKS-2022 - DeviceBinding Device Binding~~ SDKS-1747 / SDKS-2022 - DeviceBinding/Verifier Sep 16, 2022

jeyanthanperiyasamy changed the title ~~SDKS-1747 / SDKS-2022 - DeviceBinding/Verifier~~ SDKS-1747 / SDKS-2022 - DeviceBinding/Verifier - Do not merge to develop Sep 16, 2022

sonatype-lift bot reviewed Sep 16, 2022

View reviewed changes

spetrov approved these changes Sep 29, 2022

View reviewed changes

spetrov merged commit 8339b1e into develop Sep 29, 2022

spetrov deleted the SDKS-1747-DeviceBind branch September 29, 2022 20:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDKS-1747 / SDKS-2022 - DeviceBinding/Verifier - Do not merge to develop #184

SDKS-1747 / SDKS-2022 - DeviceBinding/Verifier - Do not merge to develop #184

jeyanthanperiyasamy commented Aug 10, 2022

sonatype-lift bot Aug 10, 2022

sonatype-lift bot Aug 10, 2022

sonatype-lift bot Aug 10, 2022

sonatype-lift bot Aug 10, 2022

sonatype-lift bot Aug 11, 2022

sonatype-lift bot Aug 15, 2022

witrisna Aug 16, 2022

jeyanthanperiyasamy Aug 16, 2022

jeyanthanperiyasamy Aug 16, 2022

sonatype-lift bot Aug 25, 2022

spetrov left a comment

sonatype-lift bot Sep 16, 2022

spetrov left a comment

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

SDKS-1747 / SDKS-2022 - DeviceBinding/Verifier - Do not merge to develop #184

SDKS-1747 / SDKS-2022 - DeviceBinding/Verifier - Do not merge to develop #184

Conversation

jeyanthanperiyasamy commented Aug 10, 2022

JIRA Ticket

Description

Definition of Done Checklist:

sonatype-lift bot Aug 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 10, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 11, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 15, 2022

Choose a reason for hiding this comment

witrisna Aug 16, 2022

Choose a reason for hiding this comment

jeyanthanperiyasamy Aug 16, 2022

Choose a reason for hiding this comment

jeyanthanperiyasamy Aug 16, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 25, 2022

Choose a reason for hiding this comment

spetrov left a comment

Choose a reason for hiding this comment

sonatype-lift bot Sep 16, 2022

Choose a reason for hiding this comment

spetrov left a comment

Choose a reason for hiding this comment