FC007: Exclude recipes w/ embedded expr, refs #44.

features/007_check_for_undeclared_recipe_dependencies.feature

@@ -19,10 +19,15 @@ Feature: Check for undeclared recipe dependencies
     When I check the cookbook
     Then the undeclared dependency warning 007 should not be displayed
 
-  Scenario: Cookbook includes recipe via expression (embedded)
-    Given a cookbook recipe that includes a recipe name from an embedded expression
+  Scenario Outline: Cookbook includes recipe via expression (embedded)
+    Given a cookbook recipe that includes a recipe name from an embedded expression <recipe_expression>
     When I check the cookbook
     Then the undeclared dependency warning 007 should not be displayed
+  Examples:
+    | recipe_expression              |
+    | foo::#{node['foo']['fighter']} |
+    | #{cookbook_name}::other        |
+    | #{cbk}_other::other            |
 
   Scenario: Cookbook includes declared recipe dependency
     Given a cookbook recipe that includes a declared recipe dependency

features/step_definitions/cookbook_steps.rb

@@ -266,11 +266,10 @@
   }
 end
 
-Given /^a cookbook recipe that includes a recipe name from an( embedded)? expression$/ do |embedded|
+Given /^a cookbook recipe that includes a recipe name from an( embedded)? expression(.*)$/ do |embedded, expr|
   if embedded
-    # deliberately not evaluated
-    write_recipe %q{
-      include_recipe "foo::#{node['foo']['fighter']}"
+    write_recipe %Q{
+      include_recipe "#{expr.strip}"
     }
   else
     write_recipe %q{

lib/foodcritic/api.rb

@@ -142,8 +142,8 @@ def included_recipes(ast)
       raise_unless_xpath!(ast)
       # we only support literal strings, ignoring sub-expressions
       included = ast.xpath(%q{//command[ident/@value = 'include_recipe'][count(
-        descendant::args_add) = 1][descendant::args_add/string_literal]/
-        descendant::tstring_content})
+        descendant::args_add) = 1][count(descendant::string_embexpr) = 0]
+        [descendant::args_add/string_literal]/descendant::tstring_content})
       included.inject(Hash.new([])){|h, i| h[i['value']] += [i]; h}
     end