FC032: Invalid notification timing.

features/032_check_for_invalid_notification_timing.feature

@@ -0,0 +1,22 @@
+Feature: Check for invalid notification timings
+
+  In order to flag invalid notifications more quickly
+  As a developer
+  I want to identify notifications that have an invalid timing type
+
+  Scenario Outline: Notification timings
+    Given a cookbook recipe with a resource that <type> <notification_timing>
+    When I check the cookbook
+    Then the invalid notification timing warning 032 <display> be displayed
+  Examples:
+    | type       | notification_timing | display     |
+    | notifies   |                     | should not  |
+    | notifies   | immediately         | should not  |
+    | notifies   | immediate           | should not  |
+    | notifies   | delayed             | should not  |
+    | notifies   | imediately          | should      |
+    | subscribes |                     | should not  |
+    | subscribes | immediately         | should not  |
+    | subscribes | immediate           | should not  |
+    | subscribes | delayed             | should not  |
+    | subscribes | imediately          | should      |

features/step_definitions/cookbook_steps.rb

@@ -355,6 +355,14 @@
   }.strip
 end
 
+Given /^a cookbook recipe with a resource that ([^ ]+) (.*)$/ do |type,notification_timing|
+  write_recipe %Q{
+    template "/etc/foo.conf" do
+      #{type} :restart, "service[foo]"#{", :#{notification_timing}" if notification_timing}
+    end
+  }
+end
+
 Given /^a cookbook recipe with a '([^']+)' condition for flavours (.*)$/ do |type,flavours|
   platforms = %Q{"#{flavours.split(',').join('","')}"}
   if type == 'case'

features/support/command_helpers.rb

@@ -38,6 +38,7 @@ module CommandHelpers
       'FC029' => 'No leading cookbook name in recipe metadata',
       'FC030' => 'Cookbook contains debugger breakpoints',
       'FC031' => 'Cookbook without metadata file',
+      'FC032' => 'Invalid notification timing',
       'FCTEST001' => 'Test Rule'
     }
 

lib/foodcritic/rules.rb

@@ -443,3 +443,14 @@
     end
   end
 end
+
+rule "FC032", "Invalid notification timing" do
+  tags %w{correctness notifications}
+  recipe do |ast|
+    find_resources(ast).select do |resource|
+      notifications(resource).any? do |notification|
+        ! [:delayed, :immediate].include? notification[:timing]
+      end
+    end
+  end
+end