Add more conformant unicode handling #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ test('github test cases', function (t) { | |||
| var slugger = new GithubSlugger() | |||
|
|
|||
| testCases.forEach(function (test) { | |||
| t.equals(test.slug, slugger.slug(test.text), test.mesg) | |||
| t.equals(slugger.slug(test.text), test.slug, test.mesg) | |||
There was a problem hiding this comment.
First argument should be the actual, second expected, this threw me off 😉
There was a problem hiding this comment.
Thanks, I get this confused a lot :)
|
I'll leave code style up to @Flet, but this gets a 👍 from me. |
|
Looks excellent to me, thanks @wooorm for spending time on this! |
|
published as |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures emoji are correctly stripped (GH-4), and non-Latin
characters are not incorrectly lower-cased (GH-6), and adds a bunch of
(verified) test cases to ensure the future holds less broken builds.
Closes GH-4.
Closes GH-6. (EDIT, commit message refers to 5 :o)
Closes GH-8.
@Flet Does this conform to your coding style?
/cc @revin