Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Russian letters must not be converted to lowercase #6

Closed
vithar opened this issue Apr 26, 2016 · 1 comment
Closed

Russian letters must not be converted to lowercase #6

vithar opened this issue Apr 26, 2016 · 1 comment

Comments

@vithar
Copy link

vithar commented Apr 26, 2016

GitHub does not convert russian letters to lowercase, see

https://github.com/bem/bem-method/blob/bem-info-data/faq/faq.ru.md#В-чем-отличие-БЭМ-от-oocss-amcss-smacss-suitcss

as example.

Use something like this

if (!maintainCase) string = string.replace(/([A-Z])+/g, function(s) { return s.toLowerCase() });

instead of

if (!maintainCase) string = string.toLowerCase()

//cc @tadatuta
wooorm added a commit that referenced this issue Apr 26, 2016
@wooorm
Add more conformant unicode handling
27fcdfc 
This update ensures emoji are correctly stripped (GH-4), and non-Latin
characters are not incorrectly lower-cased (GH-6), and adds a bunch of
(verified) test cases to ensure the future holds less broken builds.

Closes GH-4.
Closes GH-5.
Closes GH-8.
@wooorm wooorm mentioned this issue Apr 26, 2016
Merged
@Flet Flet closed this as completed in #8 Apr 26, 2016
@vithar
Copy link
Author

vithar commented Apr 26, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vithar