Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add suppressor of CA1707 for test methods #97

Merged
merged 12 commits into from
Mar 20, 2022

Conversation

Flash0ver
Copy link
Owner

closes #96

Changes

Facts

  • DiagnosticSuppressors are available since Roslyn 3.3.1

@Flash0ver Flash0ver added this to the vNext milestone Mar 6, 2022
Copy link
Collaborator

@TimoHeiten TimoHeiten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tbh I cannot check for the domain at this place & time because I do not understand what´s going on :D

As a remark:
there are some places where you use the same method call with pretty much the same parameters (string equals with ordinal or stringbuilder with \t- as prefix etc.)
Maybe create a local function so you dont have to copy paste everything if it might change. DRY but its absolutely a non issue and only my personal style.

@Flash0ver
Copy link
Owner Author

Thanks for your reviews and feedback.

During deduplicating, I actually found that I've missed two Ordinal string comparisons via StartsWith previously, which I think did then a StringComparison.CurrentCulture comparison.

@Flash0ver Flash0ver merged commit 66a4543 into main Mar 20, 2022
@Flash0ver Flash0ver deleted the feat/allow-underscores-in-tests branch March 20, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress CA1707 for unit test methods
3 participants