-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add suppressor of CA1707 for test methods #97
Conversation
suppresses CA1707 on MSTest, NUnit and xUnit.net test methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tbh I cannot check for the domain at this place & time because I do not understand what´s going on :D
As a remark:
there are some places where you use the same method call with pretty much the same parameters (string equals with ordinal or stringbuilder with \t- as prefix etc.)
Maybe create a local function so you dont have to copy paste everything if it might change. DRY but its absolutely a non issue and only my personal style.
Visual Studio 2022 version 17.0 Release Notes
Thanks for your reviews and feedback. During deduplicating, I actually found that I've missed two |
closes #96
Changes
Microsoft.CodeAnalysis.Testing
packagesDiagnosticSuppressor
sDiagnosticSuppressor
dotnet/roslyn-sdk#942DiagnosticSuppressor
s.globalconfig
if not applicable to project typeMicrosoft.CodeAnalysis.Analyzers
Facts
DiagnosticSuppressor
s are available since Roslyn 3.3.1