-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to serve as Ember CLI Addon. #76
Conversation
Also, the reason for moving to |
|
||
function EmberCLIEmberFire(project) { | ||
this.project = project; | ||
this.name = 'Ember CLI Pretender'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be changed to "EmberFire"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you are correct. Will update shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
* Add Ember CLI addon. * Add grunt copy task to prepare vendor/ subdirectory for publishing to NPM. * Adds `ember-cli-addon` keyword (and `firebase`). You will need to publish to NPM, but then once 0.0.35 is published users can simply run `npm install --save-dev emberfire`, and it **just works**.
ember-cli/ember-cli#1052 has been merged, and will be released in 0.0.35. Once merged, you will need to publish to npm via @aputinski - This is ready if you are +1. |
@rjackson I'll merge and publish later this afternoon. Thanks again for your help! |
@@ -2,7 +2,8 @@ | |||
"name": "EmberFire", | |||
"version": "1.0.9", | |||
"description": "An officially supported Ember binding for Firebase.", | |||
"main": "dist/emberfire.js", | |||
"main": "vendor/emberFire/dist/emberfire.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjackson after I merge this, will changing main
back to dist/emberfire.js
break anything? I just want to have package.json
and bower.json
pointing at the same file.
@aputinski friendly reminder |
Update to serve as Ember CLI Addon.
ember-cli-addon
keyword (andfirebase
).You will need to publish to NPM, but then once 0.0.35 is published users can simply run
npm install --save-dev emberfire
, and it just works.Closes #75.