Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to serve as Ember CLI Addon. #76

Merged
merged 1 commit into from
Jun 18, 2014

Conversation

rwjblue
Copy link
Contributor

@rwjblue rwjblue commented Jun 16, 2014

  • Add Ember CLI addon.
  • Add grunt copy task to prepare vendor/ subdirectory for publishing to NPM.
  • Adds ember-cli-addon keyword (and firebase).

You will need to publish to NPM, but then once 0.0.35 is published users can simply run npm install --save-dev emberfire, and it just works.

Closes #75.

@rwjblue
Copy link
Contributor Author

rwjblue commented Jun 16, 2014

Also, the reason for moving to vendor for publishing to NPM is so that users can simply update their bower.json to get a more recent version (since the vendor tree is merged in the output and applications vendor/ dir will win any conflicts).


function EmberCLIEmberFire(project) {
this.project = project;
this.name = 'Ember CLI Pretender';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be changed to "EmberFire"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you are correct. Will update shortly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

* Add Ember CLI addon.
* Add grunt copy task to prepare vendor/ subdirectory for publishing to
  NPM.
* Adds `ember-cli-addon` keyword (and `firebase`).

You will need to publish to NPM, but then once 0.0.35 is published users
can simply run `npm install --save-dev emberfire`, and it **just
works**.
@rwjblue
Copy link
Contributor Author

rwjblue commented Jun 17, 2014

ember-cli/ember-cli#1052 has been merged, and will be released in 0.0.35.

Once merged, you will need to publish to npm via npm publish.

@aputinski - This is ready if you are +1.

@aputinski
Copy link
Collaborator

@rjackson I'll merge and publish later this afternoon. Thanks again for your help!

@@ -2,7 +2,8 @@
"name": "EmberFire",
"version": "1.0.9",
"description": "An officially supported Ember binding for Firebase.",
"main": "dist/emberfire.js",
"main": "vendor/emberFire/dist/emberfire.js",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjackson after I merge this, will changing main back to dist/emberfire.js break anything? I just want to have package.json and bower.json pointing at the same file.

@stefanpenner
Copy link
Collaborator

@aputinski friendly reminder

aputinski added a commit that referenced this pull request Jun 18, 2014
Update to serve as Ember CLI Addon.
@aputinski aputinski merged commit 3d5bfe8 into FirebaseExtended:master Jun 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new Ember CLI Addons
3 participants