Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Ember CLI Addons #75

Closed
rwjblue opened this issue Jun 16, 2014 · 9 comments · Fixed by #76
Closed

Support new Ember CLI Addons #75

rwjblue opened this issue Jun 16, 2014 · 9 comments · Fixed by #76

Comments

@rwjblue
Copy link
Contributor

rwjblue commented Jun 16, 2014

As of ember-cli/ember-cli#1025 (not yet released), it is possible to have the installation as simple as npm install --save-dev emberfire and everything just works.

Is that something you would be interested in?

@aputinski
Copy link
Collaborator

@rjackson definitely! Would that be incorporated into emberfire directly, or as a separate addon repo?

@rwjblue
Copy link
Contributor Author

rwjblue commented Jun 16, 2014

I would prefer to make it integrated directly into the existing npm package. I am working up a PR to ember-cli right now that would allow using a separate entrypoint (otherwise changing the main in package.json would be an issue for non Ember CLI NPM users).

Take a look at https://github.com/rjackson/ember-cli-pretender/blob/master/index.js for an example, but I'll PR in a few minutes with the required changes, then we can review in detail.

@rwjblue
Copy link
Contributor Author

rwjblue commented Jun 16, 2014

See ember-cli/ember-cli#1052 for what I have in mind.

@aputinski
Copy link
Collaborator

@rjackson does it matter that EmberFire is only on bower and not npm?

@rwjblue
Copy link
Contributor Author

rwjblue commented Jun 16, 2014

The idea is to add to NPM, I assumed (since you have a package.json) that y'all cared about the NPM install case and that it can't chage. Didn't want to presume we own the universe so to speak.

@rwjblue
Copy link
Contributor Author

rwjblue commented Jun 16, 2014

I would also like to publish to NPM with the dist in vendor/emberFire/emberfire.js instead of dist/, as that would allow folks to override the version via bower install --save-dev emberfire (since the vendor/ tree is merged, and the last tree wins (which would be the users application)).

@aputinski
Copy link
Collaborator

@rjackson sorry, I'm just a little confused on what I need to do on my end.

@rwjblue
Copy link
Contributor Author

rwjblue commented Jun 16, 2014

Nothing, I'm workin' up a PR. Just wanted to make sure you would like it to "just work".

@aputinski
Copy link
Collaborator

That would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants