Make Http status mapping registrable #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfangw
reviewed
Aug 14, 2020
types/errors/errors.go
Outdated
| "reflect" | ||
|
|
||
| "github.com/cosmos/cosmos-sdk/types/rest" |
types/errors/errors.go
Outdated
| @@ -87,6 +89,10 @@ var ( | |||
| ErrPanic = Register(UndefinedCodespace, 111222, "panic") | |||
| ) | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
This function needed to be moved to the rest package
types/errors/errors.go
Outdated
| @@ -87,6 +89,10 @@ var ( | |||
| ErrPanic = Register(UndefinedCodespace, 111222, "panic") | |||
| ) | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
Do we need to use init ?
IMO, the table can be filled in static time.
There was a problem hiding this comment.
add init for mapping error using RegisterHttpStatusMapping
then, is it ok to fill the table like
var (
table = HTTPStatusMappingTable{
errors.RootCodespace: {
errors.ErrUnknownAddress.ABCICode(): http.StatusNotFound,
},
}
)
this? (in rest package) (i think it can solve two problem above also)
There was a problem hiding this comment.
please make the commit for it so that let me see what you intended.
|
@kfangw thanks for your review. |
0Tech
pushed a commit
to 0Tech/finschia-sdk
that referenced
this pull request
Jul 22, 2022
Fix the bug that should be used `operator` address when `to` address is nil on CreateFTClass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step of #14
Description
Two changes for mapping http status and error
1.Make a mapping http status and error registrable using error instance.
2.Remove hard-coded error code.