fix: Send response with 404 status when quering non-exist account #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whylee259
approved these changes
Jul 9, 2020
kfangw
approved these changes
Jul 10, 2020
| type HTTPStatusMappingTable map[string]map[uint32]int | ||
|
|
||
| var ( | ||
| table = HTTPStatusMappingTable{ |
There was a problem hiding this comment.
LGTM.
However, For better structure, you'd better consider below when you work on next PR
- Do not use a constant value like 9 here. It is an error code and should be provided as a variable or named constant by the error definition.
- Provide register function which maps given error to HTTP status. If then, in each module when the error is registered the HTTP status code can be passed also.
There was a problem hiding this comment.
LGTM.
However, For better structure, you'd better consider below when you work on next PR
- Do not use a constant value like 9 here. It is an error code and should be provided as a variable or named constant by the error definition.
- Provide register function which maps given error to HTTP status. If then, in each module when the error is registered the HTTP status code can be passed also.
👍
Can we do 1 like the below?
errors.RootCodespace: {
errors.ErrUnknownAddress.ABCICode(): http.StatusNotFound,
},
|
If line/link ran CI with the version tag 0.0.1 already, it should be bumped up 0.0.2 |
The CI has already run with tag 0.0.1. we may bump up the version. |
kfangw
pushed a commit
that referenced
this pull request
Sep 24, 2020
kfangw
pushed a commit
that referenced
this pull request
Oct 28, 2020
kfangw
pushed a commit
that referenced
this pull request
Nov 17, 2020
wetcod
pushed a commit
that referenced
this pull request
Dec 8, 2020
egonspace
pushed a commit
that referenced
this pull request
Mar 22, 2021
egonspace
pushed a commit
that referenced
this pull request
Mar 23, 2021
* feat: add codespace to broadcast response (#6) * chore: expose usedCodes for document (#7) * fix: query error (#9) * fix: check internalABCICodespace (#10) * fix: check UndefinedCodespace too * Update types/errors/abci.go Co-authored-by: Yongwoo Lee <[email protected]> Co-authored-by: Yongwoo Lee <[email protected]> * fix: Send response with 404 status when quering non-exist account (#14) * chore: enable github action ci * chore: remove github access token from Dockerfile Co-authored-by: Yongwoo Lee <[email protected]> Co-authored-by: Marshall Kim <[email protected]> Co-authored-by: wonkuk_seo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mapping error and http status to send a reponse with proper http status
in this PR, map a one error. but, to be mapped all of errors
Motivation and context
https://github.com/line/link/issues/286
How has this been tested?
TBD
Screenshots (if appropriate):
Checklist: